Skip to content

Commit

Permalink
chat: disable readonly files for stable for now (#238715)
Browse files Browse the repository at this point in the history
We're still not confident that this direction is the way to go.
  • Loading branch information
connor4312 authored Jan 24, 2025
1 parent eb0da63 commit 093de79
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import { IFileService } from '../../../../../platform/files/common/files.js';
import { IInstantiationService } from '../../../../../platform/instantiation/common/instantiation.js';
import { ILogService } from '../../../../../platform/log/common/log.js';
import { bindContextKey } from '../../../../../platform/observable/common/platformObservableUtils.js';
import { IProductService } from '../../../../../platform/product/common/productService.js';
import { IProgressService, ProgressLocation } from '../../../../../platform/progress/common/progress.js';
import { IStorageService, StorageScope, StorageTarget } from '../../../../../platform/storage/common/storage.js';
import { IWorkbenchAssignmentService } from '../../../../services/assignment/common/assignmentService.js';
Expand Down Expand Up @@ -104,6 +105,7 @@ export class ChatEditingService extends Disposable implements IChatEditingServic
@IStorageService storageService: IStorageService,
@ILogService logService: ILogService,
@IExtensionService extensionService: IExtensionService,
@IProductService productService: IProductService,
) {
super();
this._applyingChatEditsFailedContextKey = applyingChatEditsFailedContextKey.bindTo(contextKeyService);
Expand Down Expand Up @@ -161,7 +163,7 @@ export class ChatEditingService extends Disposable implements IChatEditingServic
// todo@connor4312: temporary until chatReadonlyPromptReference proposal is finalized
const readonlyEnabledContextKey = chatEditingAgentSupportsReadonlyReferencesContextKey.bindTo(contextKeyService);
const setReadonlyFilesEnabled = () => {
const enabled = extensionService.extensions.some(e => e.enabledApiProposals?.includes('chatReadonlyPromptReference'));
const enabled = productService.quality !== 'stable' && extensionService.extensions.some(e => e.enabledApiProposals?.includes('chatReadonlyPromptReference'));
readonlyEnabledContextKey.set(enabled);
};
setReadonlyFilesEnabled();
Expand Down

0 comments on commit 093de79

Please sign in to comment.