Skip to content

Commit

Permalink
Accessibility - renamed IAccessibleViewImplentation to IAccessibleVie…
Browse files Browse the repository at this point in the history
…wImplementation (#238652)
  • Loading branch information
lszomoru authored Jan 24, 2025
1 parent 5089552 commit 6e740ce
Show file tree
Hide file tree
Showing 22 changed files with 52 additions and 52 deletions.
8 changes: 4 additions & 4 deletions src/vs/editor/contrib/hover/browser/hoverAccessibleViews.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { localize } from '../../../../nls.js';
import { EditorContextKeys } from '../../../common/editorContextKeys.js';
import { ContentHoverController } from './contentHoverController.js';
import { AccessibleViewType, AccessibleViewProviderId, AccessibleContentProvider, IAccessibleViewContentProvider, IAccessibleViewOptions } from '../../../../platform/accessibility/browser/accessibleView.js';
import { IAccessibleViewImplentation } from '../../../../platform/accessibility/browser/accessibleViewRegistry.js';
import { IAccessibleViewImplementation } from '../../../../platform/accessibility/browser/accessibleViewRegistry.js';
import { IContextViewService } from '../../../../platform/contextview/browser/contextView.js';
import { IHoverService } from '../../../../platform/hover/browser/hover.js';
import { IInstantiationService, ServicesAccessor } from '../../../../platform/instantiation/common/instantiation.js';
Expand All @@ -27,7 +27,7 @@ namespace HoverAccessibilityHelpNLS {
export const decreaseVerbosity = localize('decreaseVerbosity', '- The focused hover part verbosity level can be decreased with the Decrease Hover Verbosity command.', `<keybinding:${DECREASE_HOVER_VERBOSITY_ACTION_ID}>`);
}

export class HoverAccessibleView implements IAccessibleViewImplentation {
export class HoverAccessibleView implements IAccessibleViewImplementation {

public readonly type = AccessibleViewType.View;
public readonly priority = 95;
Expand All @@ -49,7 +49,7 @@ export class HoverAccessibleView implements IAccessibleViewImplentation {
}
}

export class HoverAccessibilityHelp implements IAccessibleViewImplentation {
export class HoverAccessibilityHelp implements IAccessibleViewImplementation {

public readonly priority = 100;
public readonly name = 'hover';
Expand Down Expand Up @@ -228,7 +228,7 @@ export class HoverAccessibleViewProvider extends BaseHoverAccessibleViewProvider
}
}

export class ExtHoverAccessibleView implements IAccessibleViewImplentation {
export class ExtHoverAccessibleView implements IAccessibleViewImplementation {
public readonly type = AccessibleViewType.View;
public readonly priority = 90;
public readonly name = 'extension-hover';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ import { ICodeEditorService } from '../../../browser/services/codeEditorService.
import { InlineCompletionContextKeys } from './controller/inlineCompletionContextKeys.js';
import { InlineCompletionsController } from './controller/inlineCompletionsController.js';
import { AccessibleViewType, AccessibleViewProviderId, IAccessibleViewContentProvider } from '../../../../platform/accessibility/browser/accessibleView.js';
import { IAccessibleViewImplentation } from '../../../../platform/accessibility/browser/accessibleViewRegistry.js';
import { IAccessibleViewImplementation } from '../../../../platform/accessibility/browser/accessibleViewRegistry.js';
import { ContextKeyExpr } from '../../../../platform/contextkey/common/contextkey.js';
import { ServicesAccessor } from '../../../../platform/instantiation/common/instantiation.js';
import { Disposable } from '../../../../base/common/lifecycle.js';
import { InlineCompletionsModel } from './model/inlineCompletionsModel.js';

export class InlineCompletionsAccessibleView implements IAccessibleViewImplentation {
export class InlineCompletionsAccessibleView implements IAccessibleViewImplementation {
readonly type = AccessibleViewType.View;
readonly priority = 95;
readonly name = 'inline-completions';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { AccessibleViewType, AccessibleContentProvider, ExtensionContentProvider
import { ContextKeyExpression } from '../../contextkey/common/contextkey.js';
import { ServicesAccessor } from '../../instantiation/common/instantiation.js';

export interface IAccessibleViewImplentation {
export interface IAccessibleViewImplementation {
type: AccessibleViewType;
priority: number;
name: string;
Expand All @@ -20,9 +20,9 @@ export interface IAccessibleViewImplentation {
}

export const AccessibleViewRegistry = new class AccessibleViewRegistry {
_implementations: IAccessibleViewImplentation[] = [];
_implementations: IAccessibleViewImplementation[] = [];

register(implementation: IAccessibleViewImplentation): IDisposable {
register(implementation: IAccessibleViewImplementation): IDisposable {
this._implementations.push(implementation);
return {
dispose: () => {
Expand All @@ -34,7 +34,7 @@ export const AccessibleViewRegistry = new class AccessibleViewRegistry {
};
}

getImplementations(): IAccessibleViewImplentation[] {
getImplementations(): IAccessibleViewImplementation[] {
return this._implementations;
}
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { Codicon } from '../../../../base/common/codicons.js';
import { ThemeIcon } from '../../../../base/common/themables.js';
import { localize } from '../../../../nls.js';
import { IAccessibleViewService, AccessibleViewProviderId, AccessibleViewType, AccessibleContentProvider } from '../../../../platform/accessibility/browser/accessibleView.js';
import { IAccessibleViewImplentation } from '../../../../platform/accessibility/browser/accessibleViewRegistry.js';
import { IAccessibleViewImplementation } from '../../../../platform/accessibility/browser/accessibleViewRegistry.js';
import { IAccessibilitySignalService, AccessibilitySignal } from '../../../../platform/accessibilitySignal/browser/accessibilitySignalService.js';
import { ICommandService } from '../../../../platform/commands/common/commands.js';
import { ServicesAccessor } from '../../../../platform/instantiation/common/instantiation.js';
Expand All @@ -17,7 +17,7 @@ import { getNotificationFromContext } from './notificationsCommands.js';
import { NotificationFocusedContext } from '../../../common/contextkeys.js';
import { INotificationViewItem } from '../../../common/notifications.js';

export class NotificationAccessibleView implements IAccessibleViewImplentation {
export class NotificationAccessibleView implements IAccessibleViewImplementation {
readonly priority = 90;
readonly name = 'notifications';
readonly when = NotificationFocusedContext;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { ICodeEditorService } from '../../../../../editor/browser/services/codeE
import { AccessibleDiffViewerNext } from '../../../../../editor/browser/widget/diffEditor/commands.js';
import { localize } from '../../../../../nls.js';
import { AccessibleContentProvider, AccessibleViewProviderId, AccessibleViewType } from '../../../../../platform/accessibility/browser/accessibleView.js';
import { IAccessibleViewImplentation } from '../../../../../platform/accessibility/browser/accessibleViewRegistry.js';
import { IAccessibleViewImplementation } from '../../../../../platform/accessibility/browser/accessibleViewRegistry.js';
import { ContextKeyExpr } from '../../../../../platform/contextkey/common/contextkey.js';
import { IKeybindingService } from '../../../../../platform/keybinding/common/keybinding.js';
import { ActiveAuxiliaryContext } from '../../../../common/contextkeys.js';
Expand All @@ -19,7 +19,7 @@ import { ChatAgentLocation } from '../../common/chatAgents.js';
import { ChatContextKeys } from '../../common/chatContextKeys.js';
import { IChatWidgetService } from '../chat.js';

export class PanelChatAccessibilityHelp implements IAccessibleViewImplentation {
export class PanelChatAccessibilityHelp implements IAccessibleViewImplementation {
readonly priority = 107;
readonly name = 'panelChat';
readonly type = AccessibleViewType.Help;
Expand All @@ -30,7 +30,7 @@ export class PanelChatAccessibilityHelp implements IAccessibleViewImplentation {
}
}

export class QuickChatAccessibilityHelp implements IAccessibleViewImplentation {
export class QuickChatAccessibilityHelp implements IAccessibleViewImplementation {
readonly priority = 107;
readonly name = 'quickChat';
readonly type = AccessibleViewType.Help;
Expand All @@ -41,7 +41,7 @@ export class QuickChatAccessibilityHelp implements IAccessibleViewImplentation {
}
}

export class EditsChatAccessibilityHelp implements IAccessibleViewImplentation {
export class EditsChatAccessibilityHelp implements IAccessibleViewImplementation {
readonly priority = 119;
readonly name = 'editsView';
readonly type = AccessibleViewType.Help;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ import { renderMarkdownAsPlaintext } from '../../../../base/browser/markdownRend
import { MarkdownString } from '../../../../base/common/htmlContent.js';
import { Disposable } from '../../../../base/common/lifecycle.js';
import { AccessibleViewProviderId, AccessibleViewType, IAccessibleViewContentProvider } from '../../../../platform/accessibility/browser/accessibleView.js';
import { IAccessibleViewImplentation } from '../../../../platform/accessibility/browser/accessibleViewRegistry.js';
import { IAccessibleViewImplementation } from '../../../../platform/accessibility/browser/accessibleViewRegistry.js';
import { ServicesAccessor } from '../../../../platform/instantiation/common/instantiation.js';
import { AccessibilityVerbositySettingId } from '../../accessibility/browser/accessibilityConfiguration.js';
import { ChatContextKeys } from '../common/chatContextKeys.js';
import { isResponseVM } from '../common/chatViewModel.js';
import { ChatTreeItem, IChatWidget, IChatWidgetService } from './chat.js';

export class ChatResponseAccessibleView implements IAccessibleViewImplentation {
export class ChatResponseAccessibleView implements IAccessibleViewImplementation {
readonly priority = 100;
readonly name = 'panelChat';
readonly type = AccessibleViewType.View;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@ import { AccessibleDiffViewerNext, AccessibleDiffViewerPrev } from '../../../../
import { DiffEditorWidget } from '../../../../editor/browser/widget/diffEditor/diffEditorWidget.js';
import { localize } from '../../../../nls.js';
import { AccessibleViewProviderId, AccessibleViewType, AccessibleContentProvider } from '../../../../platform/accessibility/browser/accessibleView.js';
import { IAccessibleViewImplentation } from '../../../../platform/accessibility/browser/accessibleViewRegistry.js';
import { IAccessibleViewImplementation } from '../../../../platform/accessibility/browser/accessibleViewRegistry.js';
import { ContextKeyEqualsExpr, IContextKeyService } from '../../../../platform/contextkey/common/contextkey.js';
import { ServicesAccessor } from '../../../../platform/instantiation/common/instantiation.js';
import { IKeybindingService } from '../../../../platform/keybinding/common/keybinding.js';
import { AccessibilityVerbositySettingId } from '../../accessibility/browser/accessibilityConfiguration.js';
import { getCommentCommandInfo } from '../../accessibility/browser/editorAccessibilityHelp.js';
import { IEditorService } from '../../../services/editor/common/editorService.js';

export class DiffEditorAccessibilityHelp implements IAccessibleViewImplentation {
export class DiffEditorAccessibilityHelp implements IAccessibleViewImplementation {
readonly priority = 105;
readonly name = 'diff-editor';
readonly when = ContextKeyEqualsExpr.create('isInDiffEditor', true);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { AccessibilityVerbositySettingId } from '../../accessibility/browser/acc
import { CommentCommandId } from '../common/commentCommandIds.js';
import { ToggleTabFocusModeAction } from '../../../../editor/contrib/toggleTabFocusMode/browser/toggleTabFocusMode.js';
import { IAccessibleViewContentProvider, AccessibleViewProviderId, IAccessibleViewOptions, AccessibleViewType } from '../../../../platform/accessibility/browser/accessibleView.js';
import { IAccessibleViewImplentation } from '../../../../platform/accessibility/browser/accessibleViewRegistry.js';
import { IAccessibleViewImplementation } from '../../../../platform/accessibility/browser/accessibleViewRegistry.js';
import { Disposable } from '../../../../base/common/lifecycle.js';


Expand Down Expand Up @@ -44,7 +44,7 @@ export class CommentsAccessibilityHelpProvider extends Disposable implements IAc
}
}

export class CommentsAccessibilityHelp implements IAccessibleViewImplentation {
export class CommentsAccessibilityHelp implements IAccessibleViewImplementation {
readonly priority = 110;
readonly name = 'comments';
readonly type = AccessibleViewType.Help;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { Disposable } from '../../../../base/common/lifecycle.js';
import { MarshalledId } from '../../../../base/common/marshallingIds.js';
import { ServicesAccessor } from '../../../../editor/browser/editorExtensions.js';
import { AccessibleViewProviderId, AccessibleViewType, IAccessibleViewContentProvider } from '../../../../platform/accessibility/browser/accessibleView.js';
import { IAccessibleViewImplentation } from '../../../../platform/accessibility/browser/accessibleViewRegistry.js';
import { IAccessibleViewImplementation } from '../../../../platform/accessibility/browser/accessibleViewRegistry.js';
import { IMenuService } from '../../../../platform/actions/common/actions.js';
import { IContextKeyService } from '../../../../platform/contextkey/common/contextkey.js';
import { AccessibilityVerbositySettingId } from '../../accessibility/browser/accessibilityConfiguration.js';
Expand All @@ -24,7 +24,7 @@ import { URI } from '../../../../base/common/uri.js';
import { CommentThread, Comment } from '../../../../editor/common/languages.js';
import { IRange } from '../../../../editor/common/core/range.js';

export class CommentsAccessibleView extends Disposable implements IAccessibleViewImplentation {
export class CommentsAccessibleView extends Disposable implements IAccessibleViewImplementation {
readonly priority = 90;
readonly name = 'comment';
readonly when = CONTEXT_KEY_COMMENT_FOCUSED;
Expand All @@ -50,7 +50,7 @@ export class CommentsAccessibleView extends Disposable implements IAccessibleVie
}


export class CommentThreadAccessibleView extends Disposable implements IAccessibleViewImplentation {
export class CommentThreadAccessibleView extends Disposable implements IAccessibleViewImplementation {
readonly priority = 85;
readonly name = 'commentThread';
readonly when = CommentContextKeys.commentFocused;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@

import { ServicesAccessor } from '../../../../editor/browser/editorExtensions.js';
import { AccessibleViewProviderId, AccessibleViewType, IAccessibleViewContentProvider } from '../../../../platform/accessibility/browser/accessibleView.js';
import { IAccessibleViewImplentation } from '../../../../platform/accessibility/browser/accessibleViewRegistry.js';
import { IAccessibleViewImplementation } from '../../../../platform/accessibility/browser/accessibleViewRegistry.js';
import { ContextKeyExpr } from '../../../../platform/contextkey/common/contextkey.js';
import { Disposable } from '../../../../base/common/lifecycle.js';
import { getReplView, Repl } from './repl.js';
import { IViewsService } from '../../../services/views/common/viewsService.js';
import { AccessibilityVerbositySettingId } from '../../accessibility/browser/accessibilityConfiguration.js';
import { localize } from '../../../../nls.js';

export class ReplAccessibilityHelp implements IAccessibleViewImplentation {
export class ReplAccessibilityHelp implements IAccessibleViewImplementation {
priority = 120;
name = 'replHelp';
when = ContextKeyExpr.equals('focusedView', 'workbench.panel.repl.view');
Expand Down
4 changes: 2 additions & 2 deletions src/vs/workbench/contrib/debug/browser/replAccessibleView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import { AccessibleViewProviderId, AccessibleViewType, IAccessibleViewContentProvider, IAccessibleViewService } from '../../../../platform/accessibility/browser/accessibleView.js';
import { AccessibilityVerbositySettingId } from '../../accessibility/browser/accessibilityConfiguration.js';
import { IReplElement } from '../common/debug.js';
import { IAccessibleViewImplentation } from '../../../../platform/accessibility/browser/accessibleViewRegistry.js';
import { IAccessibleViewImplementation } from '../../../../platform/accessibility/browser/accessibleViewRegistry.js';
import { ServicesAccessor } from '../../../../platform/instantiation/common/instantiation.js';
import { getReplView, Repl } from './repl.js';
import { IViewsService } from '../../../services/views/common/viewsService.js';
Expand All @@ -15,7 +15,7 @@ import { Emitter, Event } from '../../../../base/common/event.js';
import { Disposable } from '../../../../base/common/lifecycle.js';
import { Position } from '../../../../editor/common/core/position.js';

export class ReplAccessibleView implements IAccessibleViewImplentation {
export class ReplAccessibleView implements IAccessibleViewImplementation {
priority = 70;
name = 'debugConsole';
when = ContextKeyExpr.equals('focusedView', 'workbench.panel.repl.view');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

import { ServicesAccessor } from '../../../../editor/browser/editorExtensions.js';
import { AccessibleViewProviderId, AccessibleViewType, IAccessibleViewContentProvider } from '../../../../platform/accessibility/browser/accessibleView.js';
import { IAccessibleViewImplentation } from '../../../../platform/accessibility/browser/accessibleViewRegistry.js';
import { IAccessibleViewImplementation } from '../../../../platform/accessibility/browser/accessibleViewRegistry.js';
import { ContextKeyExpr } from '../../../../platform/contextkey/common/contextkey.js';
import { Disposable } from '../../../../base/common/lifecycle.js';
import { AccessibilityVerbositySettingId } from '../../accessibility/browser/accessibilityConfiguration.js';
Expand All @@ -17,7 +17,7 @@ import { AccessibilityHelpNLS } from '../../../../editor/common/standaloneString
import { FocusedViewContext, SidebarFocusContext } from '../../../common/contextkeys.js';
import { BREAKPOINTS_VIEW_ID, CALLSTACK_VIEW_ID, LOADED_SCRIPTS_VIEW_ID, VARIABLES_VIEW_ID, WATCH_VIEW_ID } from '../common/debug.js';

export class RunAndDebugAccessibilityHelp implements IAccessibleViewImplentation {
export class RunAndDebugAccessibilityHelp implements IAccessibleViewImplementation {
priority = 120;
name = 'runAndDebugHelp';
when = ContextKeyExpr.or(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@
import { ServicesAccessor } from '../../../../editor/browser/editorExtensions.js';
import { ICodeEditorService } from '../../../../editor/browser/services/codeEditorService.js';
import { AccessibleViewType } from '../../../../platform/accessibility/browser/accessibleView.js';
import { IAccessibleViewImplentation } from '../../../../platform/accessibility/browser/accessibleViewRegistry.js';
import { IAccessibleViewImplementation } from '../../../../platform/accessibility/browser/accessibleViewRegistry.js';
import { ContextKeyExpr } from '../../../../platform/contextkey/common/contextkey.js';
import { getChatAccessibilityHelpProvider } from '../../chat/browser/actions/chatAccessibilityHelp.js';
import { ChatContextKeys } from '../../chat/common/chatContextKeys.js';
import { CTX_INLINE_CHAT_RESPONSE_FOCUSED } from '../common/inlineChat.js';

export class InlineChatAccessibilityHelp implements IAccessibleViewImplentation {
export class InlineChatAccessibilityHelp implements IAccessibleViewImplementation {
readonly priority = 106;
readonly name = 'inlineChat';
readonly type = AccessibleViewType.Help;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ import { ICodeEditorService } from '../../../../editor/browser/services/codeEdit
import { ContextKeyExpr } from '../../../../platform/contextkey/common/contextkey.js';
import { AccessibleViewProviderId, AccessibleViewType, AccessibleContentProvider } from '../../../../platform/accessibility/browser/accessibleView.js';
import { ServicesAccessor } from '../../../../platform/instantiation/common/instantiation.js';
import { IAccessibleViewImplentation } from '../../../../platform/accessibility/browser/accessibleViewRegistry.js';
import { IAccessibleViewImplementation } from '../../../../platform/accessibility/browser/accessibleViewRegistry.js';
import { MarkdownString } from '../../../../base/common/htmlContent.js';
import { renderMarkdownAsPlaintext } from '../../../../base/browser/markdownRenderer.js';
import { AccessibilityVerbositySettingId } from '../../accessibility/browser/accessibilityConfiguration.js';

export class InlineChatAccessibleView implements IAccessibleViewImplentation {
export class InlineChatAccessibleView implements IAccessibleViewImplementation {
readonly priority = 100;
readonly name = 'inlineChat';
readonly when = ContextKeyExpr.or(CTX_INLINE_CHAT_FOCUSED, CTX_INLINE_CHAT_RESPONSE_FOCUSED);
Expand Down
Loading

0 comments on commit 6e740ce

Please sign in to comment.