Suggest exit keyword with score penalty #223946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthiknadig
approved these changes
Jul 26, 2024
anthonykim1
approved these changes
Jul 26, 2024
| // Keywords should always appear at the bottom when they are not an exact match | ||
| let score = 0; | ||
| if (a.completion.isKeyword && a.labelLow !== wordLow || b.completion.isKeyword && b.labelLow !== wordLow) { | ||
| score = (a.completion.isKeyword ? 1 : 0) - (b.completion.isKeyword ? 1 : 0); |
There was a problem hiding this comment.
Is this score referring to the index of suggestion? For example, would low score represent first/last thing that would show up as a suggestion
There was a problem hiding this comment.
@anthonykim1 this is fed into the a sort function such that exit in pwsh has special sorting behavior as keywords are generally unlikely to be used in the repl
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #223945