Add smart paste terminal feature #231178

Parasaran-Python · 2024-10-12T11:40:39Z

Added a new terminal feature setting to control the feature, we check for spaces or back slashes and escape or wrap in double-quotes accordingly, the unit tests have been modified accordingly.

Parasaran-Python · 2024-10-12T11:43:18Z

Hi @Tyriar ,

I've opened this PR but still need some clarity on a few aspects regarding smart paste:

Relative Paths: Should we support relative paths? If so, to what extent? Considering they can start with . or .., what should be the scope for these?

Shell Type Check: Do we really need to check for shell types? Would it be simpler to just wrap any path in quotes if it contains spaces or backslashes, regardless of the shell?

PowerShell Behavior: I've noticed that in a PowerShell terminal, the _paste function in terminal.clipboard.contribution.ts doesn't seem to trigger when pasting. However, the middle mouse click works fine. Is this something we should address as a bug?

Smart Paste behavior: Should smart paste only come into action if the entire clipboard string is a path? Or should we also consider parts of the string that might be paths and wrap or escape those?

Thank you for your help with these questions! 😊

Parasaran-Python · 2024-10-12T11:48:20Z

@Parasaran-Python please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”), and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your contributions to Microsoft open source projects. This Agreement is effective as of the latest signature date below.

1. **Definitions**.
   **“Code”** means the computer software code, whether in human-readable or machine-executable form,
   that is delivered by You to Microsoft under this Agreement.
   **“Project”** means any of the projects owned or managed by Microsoft and offered under a license
   approved by the Open Source Initiative ([www.opensource.org](http://www.opensource.org)).
   **“Submit”** is the act of uploading, submitting, transmitting, or distributing code or other content to any
   Project, including but not limited to communication on electronic mailing lists, source code control
   systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
   discussing and improving that Project, but excluding communication that is conspicuously marked or
   otherwise designated in writing by You as “Not a Submission.”
   **“Submission”** means the Code and any other copyrightable material Submitted by You, including any
   associated comments and documentation.

2. **Your Submission**. You must agree to the terms of this Agreement before making a Submission to any
   Project. This Agreement covers any and all Submissions that You, now or in the future (except as
   described in Section 4 below), Submit to any Project.

3. **Originality of Work**. You represent that each of Your Submissions is entirely Your original work.
   Should You wish to Submit materials that are not Your original work, You may Submit them separately
   to the Project if You (a) retain all copyright and license information that was in the materials as You
   received them, (b) in the description accompanying Your Submission, include the phrase “Submission
   containing materials of a third party:” followed by the names of the third party and any licenses or other
   restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
   guidelines concerning Submissions.

4. **Your Employer**. References to “employer” in this Agreement include Your employer or anyone else
   for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
   Submission is made in the course of Your work for an employer or Your employer has intellectual
   property rights in Your Submission by contract or applicable law, You must secure permission from Your
   employer to make the Submission before signing this Agreement. In that case, the term “You” in this
   Agreement will refer to You and the employer collectively. If You change employers in the future and
   desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
   and secure permission from the new employer before Submitting those Submissions.

5. **Licenses**.


* **Copyright License**. You grant Microsoft, and those who receive the Submission directly or
  indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
  Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
  the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
  parties.

* **Patent License**. You grant Microsoft, and those who receive the Submission directly or
  indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
  Your patent claims that are necessarily infringed by the Submission or the combination of the
  Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
  import or otherwise dispose of the Submission alone or with the Project.

* **Other Rights Reserved**. Each party reserves all rights not expressly granted in this Agreement.
  No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
  granted by implication, exhaustion, estoppel or otherwise.


6. **Representations and Warranties**. You represent that You are legally entitled to grant the above
   licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
   have disclosed under Section 3). You represent that You have secured permission from Your employer to
   make the Submission in cases where Your Submission is made in the course of Your work for Your
   employer or Your employer has intellectual property rights in Your Submission by contract or applicable
   law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
   have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
   You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
   REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
   EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
   PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
   NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.

7. **Notice to Microsoft**. You agree to notify Microsoft in writing of any facts or circumstances of which
   You later become aware that would make Your representations in this Agreement inaccurate in any
   respect.

8. **Information about Submissions**. You agree that contributions to Projects and information about
   contributions may be maintained indefinitely and disclosed publicly, including Your name and other
   information that You submit with Your Submission.

9. **Governing Law/Jurisdiction**. This Agreement is governed by the laws of the State of Washington, and
   the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
   Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
   exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
   defenses of lack of personal jurisdiction and forum non-conveniens.

10. **Entire Agreement/Assignment**. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

@microsoft-github-policy-service agree

Tyriar · 2024-10-14T11:40:24Z

src/vs/platform/terminal/common/terminal.ts

@@ -83,6 +83,7 @@ export const enum TerminalSettingId {
 	EnableVisualBell = 'terminal.integrated.enableVisualBell',
 	CommandsToSkipShell = 'terminal.integrated.commandsToSkipShell',
 	AllowChords = 'terminal.integrated.allowChords',
+	AllowSmartPaste = 'terminal.integrated.allowSmartPaste',


I think enableSmartPaste is more appropriate than allow*

Tyriar · 2024-10-14T11:41:00Z

src/vs/workbench/contrib/terminal/common/terminal.ts

@@ -165,6 +165,7 @@ export interface ITerminalConfiguration {
 	scrollback: number;
 	commandsToSkipShell: string[];
 	allowChords: boolean;
+	allowSmartPaste: boolean;


We want this to live entirely within terminalContrib/clipboard, including the configuration setup

Tyriar · 2024-10-14T11:41:58Z

src/vs/workbench/contrib/terminalContrib/clipboard/browser/terminal.clipboard.contribution.ts

@@ -96,8 +96,17 @@ export class TerminalClipboardContribution extends Disposable implements ITermin
 			return;
 		}

+		let shellType = '';
+
+		shellType = (this._ctx.instance as ITerminalInstance).shellType ?? '';


We should not be using as here, I think the fix here is to add shellType to IBaseTerminalInstance

Tyriar · 2024-10-14T11:43:06Z

src/vs/workbench/contrib/terminalContrib/clipboard/browser/terminalClipboard.ts

@@ -9,14 +9,84 @@ import { IDialogService } from '../../../../../platform/dialogs/common/dialogs.j
 import { ServicesAccessor } from '../../../../../platform/instantiation/common/instantiation.js';
 import { TerminalSettingId } from '../../../../../platform/terminal/common/terminal.js';

-export async function shouldPasteTerminalText(accessor: ServicesAccessor, text: string, bracketedPasteMode: boolean | undefined): Promise<boolean | { modifiedText: string }> {
+class SmartPasteUtils {


namespace smartPaste is preferable to a class containing only statics. However just moving these into a separate file inside terminalContrib/clipboard would be best

Tyriar · 2024-10-14T11:43:53Z

src/vs/workbench/contrib/terminalContrib/clipboard/browser/terminalClipboard.ts

+	 * @param string
+	 * @returns true if the string is a path
+	 */
+	static isPath(string: string): boolean {


isPathLike? This will help hint that it's not actually verifying that it's an actual path, but something that likely is.

Tyriar · 2024-10-14T11:48:14Z

src/vs/workbench/contrib/terminalContrib/clipboard/browser/terminalClipboard.ts

+	static isPath(string: string): boolean {
+		// Regex to detect common path formats
+		const windowsPathPattern = /^[a-zA-Z]:(\\|\/)/;  // Windows absolute path
+		const uncPathPattern = /^\\\\/;             // Windows UNC path


windowsUncPattern?

Tyriar · 2024-10-14T11:48:32Z

src/vs/workbench/contrib/terminalContrib/clipboard/browser/terminalClipboard.ts

+	 *
+	 * @param string
+	 * @param shellType
+	 * @returns func to handle smart paste, escape chars or wrap inside double quotes


Same as above

Tyriar · 2024-10-14T11:49:06Z

src/vs/workbench/contrib/terminalContrib/clipboard/browser/terminalClipboard.ts

+					// Escape backslashes and wrap in double quotes if necessary
+					const escapedPath = string.replace(/\\/g, '\\\\');
+					if (string.includes(' ')) {
+						return `"${escapedPath}"`;
+					}
+					return escapedPath;
+				}
+
+			case 'bash':  // Linux/macOS Bash
+				// Wrap in quotes if spaces or special characters exist
+				if (string.includes(' ')) {
+					return `"${string}"`;
+				}
+				return string;
+
+			case 'pwsh':
+				// Simply wrap in quotes if spaces are present
+				if (string.includes(' ')) {
+					return `"${string}"`;
+				}


You also need to ensure that the quote you're using is escaped properly within string

Tyriar · 2024-10-14T11:49:18Z

src/vs/workbench/contrib/terminalContrib/clipboard/browser/terminalClipboard.ts

+	 * @param shellType
+	 * @returns func to handle smart paste, escape chars or wrap inside double quotes
+	 */
+	static handleSmartPaste(string: string, shellType: string): string {


Same as above, we want to avoid a "string" var

Tyriar · 2024-10-14T11:51:48Z

src/vs/workbench/contrib/terminalContrib/clipboard/test/browser/terminalClipboard.test.ts

+		function setConfigValue(multiLinePaste: unknown, smartPaste: boolean) {
 			configurationService = new TestConfigurationService({
-				[TerminalSettingId.EnableMultiLinePasteWarning]: value
+				[TerminalSettingId.EnableMultiLinePasteWarning]: multiLinePaste,
+				[TerminalSettingId.AllowSmartPaste]: smartPaste
 			});
 			instantiationService.stub(IConfigurationService, configurationService);
 		}


Since there's another one now, tests would be easier to read if this was an object:

values: { enableMultiLinePaste?: unknown, enableSmartPaste?: boolean }

They could also default to false?

Parasaran-Python · 2024-10-14T13:14:17Z

Hi @Tyriar ,

I've opened this PR but still need some clarity on a few aspects regarding smart paste:

Relative Paths: Should we support relative paths? If so, to what extent? Considering they can start with . or .., what should be the scope for these?

Shell Type Check: Do we really need to check for shell types? Would it be simpler to just wrap any path in quotes if it contains spaces or backslashes, regardless of the shell?

PowerShell Behavior: I've noticed that in a PowerShell terminal, the _paste function in terminal.clipboard.contribution.ts doesn't seem to trigger when pasting. However, the middle mouse click works fine. Is this something we should address as a bug?

Smart Paste behavior: Should smart paste only come into action if the entire clipboard string is a path? Or should we also consider parts of the string that might be paths and wrap or escape those?

Thank you for your help with these questions! 😊

@Tyriar while I go through your comments and incorporate them, could you please check these queries? 🙂

Tyriar · 2024-10-14T16:02:26Z

@Parasaran-Python

Relative Paths: Should we support relative paths? If so, to what extent? Considering they can start with . or .., what should be the scope for these?

You could experiment with using detectLinks from terminalLinkParsing.ts which does relative paths and so much more. Maybe just calling into that and handling when IParsedLink.path matches the entire text? ie. no suffix or prefix

Shell Type Check: Do we really need to check for shell types? Would it be simpler to just wrap any path in quotes if it contains spaces or backslashes, regardless of the shell?

We could have a default path, and then tweak for shell-specific behavior as necessary.

PowerShell Behavior: I've noticed that in a PowerShell terminal, the _paste function in terminal.clipboard.contribution.ts doesn't seem to trigger when pasting. However, the middle mouse click works fine. Is this something we should address as a bug?

Pasting in PowerShell is actually handled a little specially, there's a custom keybinding which sends ^V to PSReadLine which then handles the pasting.

vscode/src/vs/workbench/contrib/terminal/browser/terminal.contribution.ts

Lines 141 to 150 in 8b7a797

    
           // An extra Windows-only ctrl+v keybinding is used for pwsh that sends ctrl+v directly to the 
        
           // shell, this gets handled by PSReadLine which properly handles multi-line pastes. This is 
        
           // disabled in accessibility mode as PowerShell does not run PSReadLine when it detects a screen 
        
           // reader. This works even when clipboard.readText is not supported. 
        
           if (isWindows) { 
        
           	registerSendSequenceKeybinding(String.fromCharCode('V'.charCodeAt(0) - Constants.CtrlLetterOffset), { // ctrl+v 
        
           		when: ContextKeyExpr.and(TerminalContextKeys.focus, ContextKeyExpr.equals(TerminalContextKeyStrings.ShellType, GeneralShellType.PowerShell), CONTEXT_ACCESSIBILITY_MODE_ENABLED.negate()), 
        
           		primary: KeyMod.CtrlCmd | KeyCode.KeyV 
        
           	}); 
        
           }

As you see in the comment this is done to properly support multi-line pasting. Not sure the best way to handle this, maybe we should only be doing that when the string is multi-line? 🤔

Smart Paste behavior: Should smart paste only come into action if the entire clipboard string is a path? Or should we also consider parts of the string that might be paths and wrap or escape those?

I think it makes the most sense only if the entire text is a path. Otherwise it would be pretty unexpected imo.

Tyriar · 2024-10-16T08:57:59Z

@Parasaran-Python fyi it's a little easier to review your change if you don't force push. Force pushing breaks diffs so I can't diff when you've newly done over what you did that i already reviewed

Parasaran-Python · 2024-10-16T09:05:23Z

Sure @Tyriar will not force push going forward, force push had become necessary as I prefer rebase over merge to have a clean linear commit history,

Fyi, have incorporated the changes, just the relative paths thing is pending.

Parasaran-Python · 2024-10-16T18:19:08Z

@Tyriar , I experimented with detectLinks and noticed an issue: it ignores anything after a space in paths that contain spaces. A relative path could be mistaken for another keyword. For example, if I have a folder named "cd dir" in my current working directory, and I try to paste "cd dir" in the terminal to access the folder "dir," the command gets wrapped in quotes. This leads to unintended behavior.

If it was just for cd we could even check if the path string exists (on device) before wrapping but this could be used with a command like mkdir as well.

I hope I was clear.

Need some clarity in this aspect, as I seem to be approaching a dead end 😕

May be the scope has to be limited to a safe extent (for relative paths).

Tyriar · 2024-10-16T21:30:50Z

I experimented with detectLinks and noticed an issue: it ignores anything after a space in paths that contain spaces. A relative path could be mistaken for another keyword

Yeah you're right, I thought it handled space paths too but that's tackled here:

vscode/src/vs/workbench/contrib/terminalContrib/links/browser/terminalLocalLinkDetector.ts

Lines 37 to 59 in 6c8fa55

    
           const fallbackMatchers: RegExp[] = [ 
        
           	// Python style error: File "<path>", line <line> 
        
           	/^ *File (?<link>"(?<path>.+)"(, line (?<line>\d+))?)/, 
        
           	// Unknown tool #200166: FILE  <path>:<line>:<col> 
        
           	/^ +FILE +(?<link>(?<path>.+)(?::(?<line>\d+)(?::(?<col>\d+))?)?)/, 
        
           	// Some C++ compile error formats: 
        
           	// C:\foo\bar baz(339) : error ... 
        
           	// C:\foo\bar baz(339,12) : error ... 
        
           	// C:\foo\bar baz(339, 12) : error ... 
        
           	// C:\foo\bar baz(339): error ...       [#178584, Visual Studio CL/NVIDIA CUDA compiler] 
        
           	// C:\foo\bar baz(339,12): ... 
        
           	// C:\foo\bar baz(339, 12): ... 
        
           	/^(?<link>(?<path>.+)\((?<line>\d+)(?:, ?(?<col>\d+))?\)) ?:/, 
        
           	// C:\foo/bar baz:339 : error ... 
        
           	// C:\foo/bar baz:339:12 : error ... 
        
           	// C:\foo/bar baz:339: error ... 
        
           	// C:\foo/bar baz:339:12: error ...     [#178584, Clang] 
        
           	/^(?<link>(?<path>.+):(?<line>\d+)(?::(?<col>\d+))?) ?:/, 
        
           	// Cmd prompt 
        
           	/^(?<link>(?<path>.+))>/, 
        
           	// The whole line is the path 
        
           	/^ *(?<link>(?<path>.+))/ 
        
           ];

Perhaps use terminalLinkParsing first and then fallback to the simpler matching?

Parasaran-Python · 2024-10-17T16:40:32Z

Thanks @Tyriar that works, the only thing that's pending now is the ctrl+v on powershell,

smart paste not working on ctrl+v on PS might be a pain, I would love to have smart paste working even with a ctrl+v action on a power shell instance 🙂

While I explore ways to achieve this please do drop suggestions if any.😊

Thanks again.

src/vs/workbench/contrib/terminal/browser/detachedTerminal.ts

Parasaran-Python · 2024-10-19T08:38:22Z

src/vs/workbench/contrib/terminal/browser/terminal.contribution.ts

-// reader. This works even when clipboard.readText is not supported.
-if (isWindows) {
-	registerSendSequenceKeybinding(String.fromCharCode('V'.charCodeAt(0) - Constants.CtrlLetterOffset), { // ctrl+v
-		when: ContextKeyExpr.and(TerminalContextKeys.focus, ContextKeyExpr.equals(TerminalContextKeyStrings.ShellType, GeneralShellType.PowerShell), CONTEXT_ACCESSIBILITY_MODE_ENABLED.negate()),


@Tyriar I have removed this and handled the ctrl+v action in "src\vs\workbench\contrib\terminalContrib\clipboard\browser\terminalClipboard.ts" itself,

this used to handle only ctrl+v action on pwsh, if the user tries to paste using right mouse click the multi line paste didn't used to work properly (Not sure if this is a bug or an expected behavior),

Now with the changes I've made the right mouse click also works as expected

It's just that we get the multi line paste alert on ctrl+v as well, which in my opinion shouldn't be an issue as this brings in consistency in the behavior.

Parasaran-Python · 2024-10-19T08:50:29Z

@Tyriar have made some changes, requesting you to re-review.

Parasaran-Python · 2024-10-19T09:28:14Z

src/vs/workbench/contrib/terminalContrib/clipboard/common/terminalClipboardConfiguration.ts

+
+export const terminalClipboardConfiguration: IStringDictionary<IConfigurationPropertySchema> = {
+	[TerminalClipboardSettingId.EnableSmartPaste]: {
+		markdownDescription: localize('terminal.integrated.enableSmartPaste', "Whether or not to allow smart paste to automatically wrap file path with double quotes"),


We dont just wrap the path with ", we just escape the \ if there are no spaces, need a text that's more clear

Tom8997 · 2024-10-19T08:46:56Z

src/vs/workbench/contrib/terminalContrib/clipboard/browser/terminalClipboard.ts

@@ -109,7 +109,7 @@ export async function shouldPasteTerminalText(accessor: ServicesAccessor, text:

 	if (result.confirmed) {
 		/* Send ctrl+v to PSReadline if its a pwsh instance */
-		if (shellType === 'pwsh') {


if (shellType === 'pwsh' && !result.singleLine) {

Tom8997 · 2024-10-20T15:51:26Z

src/vs/workbench/contrib/terminal/browser/detachedTerminal.ts

@@ -12,7 +12,7 @@ import { MicrotaskDelay } from '../../../../base/common/symbols.js';
 import { IInstantiationService } from '../../../../platform/instantiation/common/instantiation.js';
 import { TerminalCapabilityStore } from '../../../../platform/terminal/common/capabilities/terminalCapabilityStore.js';
 import { IMergedEnvironmentVariableCollection } from '../../../../platform/terminal/common/environmentVariable.js';
-import { ITerminalBackend } from '../../../../platform/terminal/common/terminal.js';
+import { ITerminalBackend, TerminalShellType } from '../../../../platform/terminal/common/terminal.js';


Suggested change

import { ITerminalBackend, TerminalShellType } from '../../../../platform/terminal/common/terminal.js';

import { ITerminalBackend, TerminalShellType } จาก ITerminalBackend,'../../../../platform/terminal/common/terminal.js';

Tom8997 · 2024-10-20T15:55:47Z

src/vs/workbench/contrib/terminal/browser/terminal.contribution.ts

 	/** The text representation of `^<letter>` is `'A'.charCodeAt(0) + 1`. */
 	CtrlLetterOffset = 64
 }

-// An extra Windows-only ctrl+v keybinding is used for pwsh that sends ctrl+v directly to the


// แมปคีย์ไบนดิ้งบางส่วนใน pwsh ไปยังคีย์ที่ไม่ได้ใช้ซึ่งจะถูกจัดการโดยตัวจัดการ PSReadLine ใน

Tom8997 · 2024-10-20T15:56:25Z

src/vs/workbench/contrib/terminal/browser/terminal.contribution.ts

 	/** The text representation of `^<letter>` is `'A'.charCodeAt(0) + 1`. */
 	CtrlLetterOffset = 64
 }

-// An extra Windows-only ctrl+v keybinding is used for pwsh that sends ctrl+v directly to the
-// shell, this gets handled by PSReadLine which properly handles multi-line pastes. This is


Suggested change

// shell, this gets handled by PSReadLine which properly handles multi-line pastes. This is

// shell integration script. This allows keystrokes that cannot be sent via VT sequences to work.

Tom8997 · 2024-10-20T15:56:51Z

src/vs/workbench/contrib/terminal/browser/terminal.contribution.ts

 	/** The text representation of `^<letter>` is `'A'.charCodeAt(0) + 1`. */
 	CtrlLetterOffset = 64
 }

-// An extra Windows-only ctrl+v keybinding is used for pwsh that sends ctrl+v directly to the
-// shell, this gets handled by PSReadLine which properly handles multi-line pastes. This is
-// disabled in accessibility mode as PowerShell does not run PSReadLine when it detects a screen


// ดู microsoft/terminal#879 (comment)

Tom8997 · 2024-10-20T18:03:24Z

src/vs/workbench/contrib/terminalContrib/clipboard/browser/terminalClipboard.ts


-export async function shouldPasteTerminalText(accessor: ServicesAccessor, text: string, bracketedPasteMode: boolean | undefined): Promise<boolean | { modifiedText: string }> {
+export async function shouldPasteTerminalText(accessor: ServicesAccessor, text: string, bracketedPasteMode: boolean | undefined, shellType: string): Promise<boolean | { modifiedText: string }> {
 	const configurationService = accessor.get(IConfigurationService);
 	const dialogService = accessor.get(IDialogService);

 	// If the clipboard has only one line, a warning should never show


Suggested change

// If the clipboard has only one line, a warning should never show

// If the clipboard has only one line, a warning should never show

Tom8997 · 2024-10-20T18:03:41Z

src/vs/workbench/contrib/terminalContrib/clipboard/browser/terminalClipboard.ts

@@ -8,15 +8,28 @@ import { IConfigurationService } from '../../../../../platform/configuration/com
 import { IDialogService } from '../../../../../platform/dialogs/common/dialogs.js';
 import { ServicesAccessor } from '../../../../../platform/instantiation/common/instantiation.js';
 import { TerminalSettingId } from '../../../../../platform/terminal/common/terminal.js';
+import { Constants } from '../../../terminal/browser/terminal.contribution.js';
+import { TerminalClipboardSettingId } from '../common/terminalClipboardConfiguration.js';


Suggested change

import { TerminalClipboardSettingId } from '../common/terminalClipboardConfiguration.js';

import { TerminalClipboardSettingId } from '../common/terminalClipboardConfiguration.js';

Tom8997 · 2024-10-20T18:03:51Z

src/vs/workbench/contrib/terminalContrib/clipboard/browser/terminal.clipboard.contribution.ts

@@ -96,8 +96,17 @@ export class TerminalClipboardContribution extends Disposable implements ITermin
 			return;
 		}

+		let shellType = '';
+


Suggested change

Tom8997 · 2024-10-20T18:06:14Z

src/vs/workbench/contrib/terminal/terminalContribExports.ts

@@ -46,6 +47,7 @@ export const terminalContribConfiguration: IConfigurationNode['properties'] = {
 	...terminalSuggestConfiguration,
 	...terminalTypeAheadConfiguration,
 	...terminalZoomConfiguration,
+	...terminalClipboardConfiguration
 };



... การกำหนดค่าเทอร์มินัลคลิปบอร์ด

Tom8997 · 2024-10-20T18:11:45Z

src/vs/workbench/contrib/terminal/browser/terminal.contribution.ts

@@ -133,22 +133,11 @@ Registry.as<IViewsRegistry>(ViewContainerExtensions.ViewsRegistry).registerViews
 // Register actions
 registerTerminalActions();

-const enum Constants {


ส่งออก const enum ค่าคงที่ {

Parasaran-Python · 2024-10-23T16:38:53Z

Hello @Tyriar , I see this PR is getting spammed, can we bring this PR to closure as soon as possible? 🙂
Thanks.

Parasaran-Python · 2024-10-29T16:03:39Z

@Tyriar could you please take a look at this when you have a moment 🙂?

Parasaran-Python · 2024-11-13T16:58:32Z

@Tyriar following up for a review 🙂

Parasaran-Python · 2024-12-07T14:29:58Z

Greetings @Tyriar , is there something missing in this PR due to which it has been kept on hold?🙂

…face

…oard | Made smart paste work even for strings pasted using ctrl+v action on pwsh

Parasaran-Python · 2025-01-07T16:12:47Z

Hello @Tyriar could you please go through my PR and let me know if there are some changes expected 🙂

vs-code-engineering bot assigned Tyriar Oct 12, 2024

Parasaran-Python force-pushed the 229280 branch 3 times, most recently from dadcc47 to 8c0e9f1 Compare October 13, 2024 12:03

Tyriar requested changes Oct 14, 2024

View reviewed changes

Tyriar changed the title ~~fix #229280~~ Add smart paste terminal feature Oct 14, 2024

Tyriar added this to the Backlog milestone Oct 14, 2024

Parasaran-Python force-pushed the 229280 branch 2 times, most recently from c775b6e to 82ed483 Compare October 15, 2024 18:06

Tom8997 reviewed Oct 19, 2024

View reviewed changes

src/vs/workbench/contrib/terminal/browser/detachedTerminal.ts Show resolved Hide resolved

Parasaran-Python commented Oct 19, 2024

View reviewed changes

Parasaran-Python requested a review from Tyriar October 19, 2024 08:47

Parasaran-Python commented Oct 19, 2024

View reviewed changes

Tom8997 reviewed Oct 23, 2024

View reviewed changes

Parasaran-Python force-pushed the 229280 branch 2 times, most recently from 5fe10fa to d3c4789 Compare December 7, 2024 14:28

Parasaran-Python force-pushed the 229280 branch from d3c4789 to d946b70 Compare December 15, 2024 07:20

Parasaran-Python added 24 commits December 21, 2024 18:46

229280: Added a terminal feature setting to allow smart paste

5a376d4

229280: Smart paste utils added to process paths based on shell type

8011c39

229280: Processing text before pasting if its a path

b77da91

229280: Fixed failing unit test cases

ab99247

229280: Corrected the shell type for pwsh

75be37f

229280: Added test cases for smart paste

83cae85

229280: Corrected regex for windows paths

b0f603f

229280: AllowSmartPaste -> EnableSmartPaste

fe056ef

229280: Moved enableSmartPaste setting to terminalClipboardConfig

adef711

229280: Moved smartPasteUtils to a separate file

ada8363

229280: Improved doc comments and func name

dd59152

229280: Improved var naming convention

3f64e3b

229280: Added non capturing groups

56042b8

229280: Wrap and escape paths

c8a1efb

229280: Importing SmartPasteUtils

066ef31

229280: Added doc comment for smartpasteutils class

3523384

229280_changes: Adding shellType param to IBaseTerminalInstance inter…

5fc1908

…face

229280: Wrapped func params in an object and defaulted param to false

8d798bb

229280_changes: Added more shell types

2a5a2fb

229280: Handling relative paths in terminal smartpaste

ba11c25

229280: Added tests for relative paths

a060f43

229280: Handling ctrl+v of pwsh in the main handler of terminal clipb…

7f14757

…oard | Made smart paste work even for strings pasted using ctrl+v action on pwsh

229280: Preventing ctrl+v on single line paste

8142c4b

229280: Escaping with a character based on the shell type

9e6d2a7

Parasaran-Python force-pushed the 229280 branch from d946b70 to 9e6d2a7 Compare December 21, 2024 13:18

Merge branch 'main' into 229280

c9e29d5

	import { ITerminalBackend, TerminalShellType } from '../../../../platform/terminal/common/terminal.js';
	import { ITerminalBackend, TerminalShellType } จาก ITerminalBackend,'../../../../platform/terminal/common/terminal.js';

	// shell, this gets handled by PSReadLine which properly handles multi-line pastes. This is
	// shell integration script. This allows keystrokes that cannot be sent via VT sequences to work.

	// If the clipboard has only one line, a warning should never show
	// If the clipboard has only one line, a warning should never show

	import { TerminalClipboardSettingId } from '../common/terminalClipboardConfiguration.js';
	import { TerminalClipboardSettingId } from '../common/terminalClipboardConfiguration.js';

Add smart paste terminal feature #231178

Are you sure you want to change the base?

Add smart paste terminal feature #231178

Conversation

Parasaran-Python commented Oct 12, 2024

Parasaran-Python commented Oct 12, 2024

Parasaran-Python commented Oct 12, 2024

Contribution License Agreement

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Parasaran-Python commented Oct 14, 2024

Tyriar commented Oct 14, 2024

Tyriar commented Oct 16, 2024

Parasaran-Python commented Oct 16, 2024

Parasaran-Python commented Oct 16, 2024

Tyriar commented Oct 16, 2024

Parasaran-Python commented Oct 17, 2024

Parasaran-Python Oct 19, 2024 • edited Loading

Choose a reason for hiding this comment

Parasaran-Python commented Oct 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Parasaran-Python commented Oct 23, 2024

Parasaran-Python commented Oct 29, 2024

Parasaran-Python commented Nov 13, 2024

Parasaran-Python commented Dec 7, 2024

Parasaran-Python commented Jan 7, 2025

Parasaran-Python Oct 19, 2024 •

edited

Loading