Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add prompt snippets support #234220

Merged
merged 77 commits into from
Dec 16, 2024
Merged

add prompt snippets support #234220

merged 77 commits into from
Dec 16, 2024

Conversation

legomushroom
Copy link
Member

@legomushroom legomushroom commented Nov 19, 2024 •
edited
Loading

@legomushroom
[prompt snippets]: working on recursive file references
160c21c
@legomushroom
[prompt snippets]: working on file contents codec
6851e91
@legomushroom
[prompt snippets]: implement the LinesCodecDecoder
eb75714
@legomushroom
[prompt snippets]: working on the SimpleTokensCodecDecoder
6a59277
@legomushroom
[prompt snippets]: implement first version of PromptSyntaxCodec
a51afcb
@legomushroom
[prompt snippets]: add Range attributes to all the tokens
fa22b83
@legomushroom
[prompt snippets]: refactoring components to standalone files
b657e9c
@legomushroom
[prompt snippets]: move out components to separate files, working on …
c248332 
…the first unit test
@legomushroom
[prompt snippets]: add the first unit test for LinesDecoder
bab2460
@legomushroom
[prompt snippets]: add first unit test for the SimpleDecoder
93d31c9
@legomushroom
[prompt snippets]: refactor SimpleDecoder logic
85ff657
@legomushroom
[prompt snippets]: make SimpleDecoder handle \t characters and im…
f729d4c 
…prove unit tests
@legomushroom
[prompt snippets]: add unit tests for the ChatbotPromptCodec codec
9500511
@legomushroom
[prompt snippets]: add unit test for the ChatbotPromptReference
c9bd431
@legomushroom
[prompt snippets]: working on enhancing prompt context
1bf4049
@legomushroom
[prompt snippets]: enahnce working set file references on submit
fc0beae
@legomushroom
[prompt snippets]: cleanup
a64fead
@legomushroom
[prompt snippets]: implement automatic references resolution on file …
1211fa7 
…variable addition
@legomushroom
[prompt snippets]: implement prompt snippets for implicit context files
1570d2c
@legomushroom
[prompt snippets]: improve implicit context file rendering
c99cd9f
@legomushroom
[prompt snippets]: remove redundant ChatReference class
833efd4
@legomushroom
[prompt snippets]: PromptReference can now subscribe to filesystem …
eeb2a2f 
…changes, added unit test for the `assertDefined` util
@legomushroom
[prompt snippets]: make LinesDecoder to also emit NewLine tokens,…
f9b4ff8 
… add more unit tests for it
@legomushroom
[prompt snippets]: resolve nested references for dynamic variables an…
0696dfa 
…d update variable label
@legomushroom
[prompt snippets]: add nested file references to implicit context of …
02c65fd 
…prompt request
@legomushroom
[prompt snippets]: variable hover label now includes nested file refe…
37b1557 
…rences
@legomushroom
[prompt snippets]: add the TestDecoder and TestLinesDecoder reusa…
9f99306 
…ble test utilities
@legomushroom
[prompt snippets]: add unit tests for ChatbotPromptDecoder decoder
46480da
@legomushroom
[prompt snippets]: refactor decoders to eliminate static type hacks
9ac9fa2
@legomushroom
[prompt snippets]: improve BaseDecoder logic and docs
a475982
@legomushroom
Copy link
Member Author

@roblourens

It's fine to check this in so we can try it but I'm not really seeing the utility of it, it takes up a lot of space and what do I do with this information? I think I'd rather just see this when I hover, but I'll have to try it out.

You mean the +N more label right? I've received similar feedback before and happy to remove it altogether. I've tried to avoid silent errors when users think that some files are included but they are not. The fact that there is no "compilation" or pre-run checks on the file tree can easily lead to the confusing cases for the user.

Also seems to be missing from the attachment pill.

No attachments included in this PR. Please see https://github.com/microsoft/vscode-internalbacklog/issues/5220#issuecomment-2486738649 for info on what's included.

roblourens added a commit that referenced this pull request Dec 2, 2024
@roblourens
Filter out invalid dynamic variable data (#235015)
ccda7f5 
Got this when switching off of the #234220 branch due to invalid objects in history
@legomushroom legomushroom force-pushed the legomushroom/prompt-snippet-completions branch from 64529fb to a1db921 Compare December 11, 2024 18:26
@joyceerhl joyceerhl modified the milestones: November 2024, November 2024 Recovery 1 Dec 11, 2024
@joyceerhl
Copy link
Collaborator

joyceerhl commented Dec 11, 2024 •
edited
Loading

fyi @legomushroom I moved this to the January 2025 milestone

@joyceerhl joyceerhl modified the milestones: November 2024 Recovery 1, January 2025 Dec 11, 2024
@legomushroom legomushroom force-pushed the legomushroom/prompt-snippet-completions branch from a1db921 to 40790c7 Compare December 11, 2024 21:56
@legomushroom legomushroom force-pushed the legomushroom/prompt-snippet-completions branch from 40790c7 to f29ed30 Compare December 11, 2024 22:00
@legomushroom legomushroom force-pushed the legomushroom/prompt-snippet-completions branch from defa368 to d28b027 Compare December 16, 2024 18:00
@legomushroom legomushroom force-pushed the legomushroom/prompt-snippet-completions branch from 3b04f71 to 783c3eb Compare December 16, 2024 22:02
roblourens
roblourens previously approved these changes Dec 16, 2024
View reviewed changes
@legomushroom legomushroom merged commit 8264792 into main Dec 16, 2024
8 checks passed
@legomushroom legomushroom deleted the legomushroom/prompt-snippet-completions branch December 16, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roblourens roblourens roblourens approved these changes

@joyceerhl joyceerhl Awaiting requested review from joyceerhl

Assignees

@legomushroom legomushroom

Labels
None yet
Projects
None yet
Milestone
January 2025
Development

Successfully merging this pull request may close these issues.
3 participants
@legomushroom @roblourens @joyceerhl