fix: corrupted vsce dotnet binaries in rpm package #238636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
force-pushed
the
robo/fix_rpm_stripping_for_dotnet_binaries
branch
from
9201848 to
8345ad8
Compare
|
There is a 10MB increase in final installed package size due to other elf binaries not being stripped (this just aligns with what we get from deb today). I will have a followup PR that performs binary stripping outside the packaging step so that we can exclude vsce-sign binary from it. The change in this PR fixes extension verification being broken on linux when installed via rpm |
chrmarti
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #223455