Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: Keybase.Keybase version 6.2.4 #135242

Merged
merged 2 commits into from
Jan 24, 2024
Merged

New version: Keybase.Keybase version 6.2.4 #135242

merged 2 commits into from
Jan 24, 2024

Conversation

orgcontrib
Copy link
Contributor

@orgcontrib orgcontrib commented Jan 17, 2024

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@orgcontrib
Copy link
Contributor Author

@microsoft-github-policy-service agree

@mdanish-kh
Copy link
Contributor

@wingetbot run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain labels Jan 22, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 22, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain Needs-Author-Feedback This needs a response from the author. labels Jan 23, 2024
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 23, 2024
@stephengillie
Copy link
Collaborator

Hi @orgcontrib,

This PR's version number 6.2.4 has 3 parameters (sets of numbers between dots - major, minor, etc), which is less than the current manifest's version 6.1.0.4, which has 4 parameters.

Is this intentional?

(Automated response - build 629)

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Jan 23, 2024
@orgcontrib
Copy link
Contributor Author

Hi @orgcontrib,

This PR's version number 6.2.4 has 3 parameters (sets of numbers between dots - major, minor, etc), which is less than the current manifest's version 6.1.0.4, which has 4 parameters.

Is this intentional?

(Automated response - build 629)

Yes and No. I want to keep it simple, and since this is a community effort, SymVer or SemVer matters less for me as long as there is no direct integration between upstream repo and this one. I'm a simple user of this app, and the main reason why I decided to contribute to its pkg refresh here is the recent problem with an expired x509 certificate.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 23, 2024
@stephengillie stephengillie removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 24, 2024
@stephengillie
Copy link
Collaborator

stephengillie commented Jan 24, 2024

Edit: Automation getting away from me, sorry.

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Jan 24, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 6313611 into microsoft:master Jan 24, 2024
8 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 24, 2024
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@orgcontrib orgcontrib deleted the Keybase.Keybase-6.2.4-3c686964-b18f-4663-9b6d-36efba91e3f3 branch January 26, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Author-Feedback This needs a response from the author. Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Update Request]: Keybase v6.2.4
4 participants