Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: Microsoft.VCRedist.2015+.arm64 version 14.38.33130.0 #136931

Conversation

CoolPlayLin
Copy link
Contributor

@CoolPlayLin CoolPlayLin commented Jan 29, 2024

Pull request has been created with komac v2.0.1 🚀

This also could help merge #136918

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Internal-Error-NoSupportedArchitectures The test to validate architectures submitted in the manifest failed. labels Jan 29, 2024
@CoolPlayLin
Copy link
Contributor Author

Why?
CC @stephengillie @Trenly

Copy link
Contributor

@Trenly Trenly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package already exists as Microsoft.VCRedist.2022.arm64 - the manifest should be placed there

@Trenly
Copy link
Contributor

Trenly commented Jan 29, 2024

Why? CC @stephengillie @Trenly

Internal-Error-NoSupportedArchitectures The test to validate architectures submitted in the manifest failed. means the pipelines don't have a runnner to support validating Arm64 images. If a manifest only contains an Arm64 installer, that error will be thrown

@CoolPlayLin
Copy link
Contributor Author

This package already exists as Microsoft.VCRedist.2022.arm64 - the manifest should be placed there

Hi @russellbanks
Does Komac require Microsoft.VCRedist.2022.arm64 or this package?

CC @sitiom

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 29, 2024
@sitiom
Copy link
Contributor

sitiom commented Jan 29, 2024

This package already exists as Microsoft.VCRedist.2022.arm64 - the manifest should be placed there

Why is the arm64 version placed in 2022 instead of 2015+?

@CoolPlayLin CoolPlayLin requested a review from Trenly January 29, 2024 10:51
@Trenly
Copy link
Contributor

Trenly commented Jan 29, 2024

This package already exists as Microsoft.VCRedist.2022.arm64 - the manifest should be placed there

Why is the arm64 version placed in 2022 instead of 2015+?

Because a long time ago when the packages were moved to be in their current structure, thats where it got placed. The x64 and x86 installers had the package names of 2015-2019, 2015-2020, a d 2015-2022, where newer versions will overwrite the older ones and so they were grouped together into 2015+. But, the arm64 versions in the repo at the time were only listed as 2019 and 2022, so they were left as their individual packages

@ItzLevvie
Copy link
Contributor

Close with reason: See above;

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Changes-Requested Changes Requested Internal-Error-NoSupportedArchitectures The test to validate architectures submitted in the manifest failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Package Request]: Microsoft.VCRedist.2015+.arm64
5 participants