-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Table #9
base: main
Are you sure you want to change the base?
Create Table #9
Conversation
jonathanmunamire
commented
Jan 16, 2023
- Create a database named vet_clinic.
- Create a table named animals
- Copy the SQL in schema.sql, data.sql and queries.sql
- These are the results of the queries:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jonathanmunamire,
Good job so far!
To Highlight! 👏 🟢
✔️ Good commit messages
✔️ Clean and organized code
There are some issues that you still need to work on to get this project approved, but you are almost there!
Status: Requires Changes ♻️
Check the comments below and under the review.
- Kindly update your readme file to reflect the changes for this milestone. It is a good thing you are using the template from Microverse, kindly update all the sections of your readme file with information pertaining to your project, especially the
project title, authors and getting started sections
.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
N/A
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear or you can get to me on slack using this handle @Mihndim.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved ✔
Hi @jonathanmunamire,
Great job, Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
(Highlights) Good Points: 👍
- You documented your work professionally. ✔
- You used the correct workflow. ✔
- All linters checks are ok. ✔
(Changes Required) Aspects to improve: ♻️
- N/A
[Optional] suggestions:
- N/A
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
**Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear, and please remember to tag me in your question so I can receive the notification**
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.