Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review hellow microverse project #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions Hello Microverse.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
<html>

<head>
<title>My Web Page</title>

</head>

<style>
h1 {
font-size: 18pt;
font-family: tahoma;
color: #CC3300;
}

Comment on lines +8 to +14
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove style from the HTML page and put it in the CSS page.
This is good for showing page readability.

h2 {
font-size: 14pt;
font-family: bookman, oldstyle;
color: green;
}
</style>

<body>
<h1>Hello Microverse!</h1>
<h2>it's my first web project</h2>

</body>

</html>
56 changes: 23 additions & 33 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,61 +1,51 @@
![](https://img.shields.io/badge/Microverse-blueviolet)
# Hellow Microverse
> This is a first project with Microverse.

# Project Name
![screenshot](https://github.com/mohamedelshamy55/readme-template/blob/mohamedelshamy55-patch-1/site_screenshote.png)

Comment on lines +4 to 5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I suggest you make your comments clearer so that students can understand what is expected of them

> One paragraph statement about the project.

![screenshot](./app_screenshot.png)

Additional description about the project and its features.

## Built With
- HTML
- CSS

- Major languages
- Frameworks
- Technologies used
## Getting Started

## Live Demo

[Live Demo Link](https://livedemo.com)
**Porject's features are added into seperate branch to keep main branch safe.**


## Getting Started

**This is an example of how you may give instructions on setting up your project locally.**
**Modify this file to match your project, remove sections that don't apply. For example: delete the testing section if the currect project doesn't require testing.**
To get a local copy up and running follow these simple example steps.

- create a new folder
- acccess the folder via command line

To get a local copy up and running follow these simple example steps.

### Prerequisites
-Html
-CSS
-Git

### Setup
-None


### Install
-Git

### Usage
-None

### Run tests
-None

### Deployment
-None
Comment on lines 28 to +42

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Kindly make your comments clear and easy to understand. For Example:

This is a clear comment: The README's "Built With" and "Getting Started" sections are currently empty. Why don't you add content, listing the technology used in the project and how to run it, to them so your README is more informative and professional?

This is a vague comment: The README is not descriptive, why don't you make it better?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two README files. One in main branch and one in htmlcss-branch. Which one should I change?


👤 Author


## Authors

👤 **Author1**

- GitHub: [@githubhandle](https://github.com/githubhandle)
- Twitter: [@twitterhandle](https://twitter.com/twitterhandle)
- LinkedIn: [LinkedIn](https://linkedin.com/in/linkedinhandle)

👤 **Author2**

- GitHub: [@githubhandle](https://github.com/githubhandle)
- Twitter: [@twitterhandle](https://twitter.com/twitterhandle)
- LinkedIn: [LinkedIn](https://linkedin.com/in/linkedinhandle)

## 🤝 Contributing
GitHub: https://github.com/mohamedelshamy55
Twitter: https://mobile.twitter.com/moelshamy55
LinkedIn: https://www.linkedin.com/in/mohamed-elshamy85/

Contributions, issues, and feature requests are welcome!

Expand Down
17 changes: 17 additions & 0 deletions index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Hello Microverse !</title>
<link rel="stylesheet" href="./styles.css">
</head>
<body>
<!-- fix linters error-->
<header>
<h1 class="header-tittle">Hello Microverse</h1>
<h2 class="body-tittle">it's first project</h2>
</header>
</body>
</html>
19 changes: 19 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions readme-template/MIT.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
## Copyright 2021, [YOUR NAME]

###### Please delete this line and the next one
###### APP TYPE can be a webpage/website, a web app, a software and so on

Permission is hereby granted, free of charge, to any person obtaining a copy of this [APP TYPE] and associated documentation files, to deal in the [APP TYPE] without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the [APP TYPE], and to permit persons to whom the [APP TYPE] is furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the [APP TYPE].

THE [APP TYPE] IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE [APP TYPE] OR THE USE OR OTHER DEALINGS IN THE [APP TYPE].
76 changes: 76 additions & 0 deletions readme-template/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
![](https://img.shields.io/badge/Microverse-blueviolet)

# Project Name

> One paragraph statement about the project.

![screenshot](./app_screenshot.png)

Additional description about the project and its features.

## Built With

- Major languages
- Frameworks
- Technologies used

## Live Demo

[Live Demo Link](https://livedemo.com)


## Getting Started

**This is an example of how you may give instructions on setting up your project locally.**
**Modify this file to match your project, remove sections that don't apply. For example: delete the testing section if the currect project doesn't require testing.**


To get a local copy up and running follow these simple example steps.

### Prerequisites

### Setup

### Install

### Usage

### Run tests

### Deployment



## Authors

👤 **Author1**

- GitHub: [@githubhandle](https://github.com/githubhandle)
- Twitter: [@twitterhandle](https://twitter.com/twitterhandle)
- LinkedIn: [LinkedIn](https://linkedin.com/in/linkedinhandle)

👤 **Author2**

- GitHub: [@githubhandle](https://github.com/githubhandle)
- Twitter: [@twitterhandle](https://twitter.com/twitterhandle)
- LinkedIn: [LinkedIn](https://linkedin.com/in/linkedinhandle)

## 🤝 Contributing

Contributions, issues, and feature requests are welcome!

Feel free to check the [issues page](../../issues/).

## Show your support

Give a ⭐️ if you like this project!

## Acknowledgments

- Hat tip to anyone whose code was used
- Inspiration
- etc

## 📝 License

This project is [MIT](./MIT.md) licensed.
Binary file added readme-template/app_screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added site_screenshote.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 9 additions & 0 deletions styles.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
/* stylesheet */
.header-tittle {
font-size: 18pt;
mohamedelshamy55 marked this conversation as resolved.
Show resolved Hide resolved
color: green;
}
.body-tittle{
font-size: 10pt;
color: red;
}
7 changes: 7 additions & 0 deletions workspace.code-workspace
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"folders": [
{
"path": "."
}
]
}