Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix header background color #257

Closed
wants to merge 2 commits into from
Closed

fix header background color #257

wants to merge 2 commits into from

Conversation

felixicaza
Copy link
Contributor

@felixicaza felixicaza commented Jan 8, 2023

This is related with the issue #248.

I'm proposing a new color for the background header, because it does not have good contrast with the team logos.

Current:

Screenshot_2023-01-08_08-48-39

(Edit: update proposals)

Option 1:

Screenshot_2023-01-08_12-10-59

Option 2 (add black border - pending to commit):

Screenshot_2023-01-08_12-14-30

Option 3 (add shadow - pending to commit):

Screenshot_2023-01-08_12-09-50

@1fbr
Copy link
Contributor

1fbr commented Jan 8, 2023

I assume the current one is like that to try to match the design of the logo.
Can you add a black outline to your proposal?
I think it could combine the two proposals well.

@felixicaza
Copy link
Contributor Author

I assume the current one is like that to try to match the design of the logo. Can you add a black outline to your proposal? I think it could combine the two proposals well.

Yes, I also like the style to match the logo design, but it doesn't have good contrast with some logos, so I just reversed the colors.

I don't understand about the black outline, can you provide a reference? So I could give it a try.

@1fbr
Copy link
Contributor

1fbr commented Jan 8, 2023

Yes, I also like the style to match the logo design, but it doesn't have good contrast with some logos, so I just reversed the colors.
I don't understand about the black outline, can you provide a reference? So I could give it a try.

Yes, I like the way you have inverted the colour.
My suggestion is to add an extra black outline. So it would be, black - yellow - black - yellow like the logo.
The original has this black outline, notice when this line connects with the logo, it looks better in my opinion.

@felixicaza
Copy link
Contributor Author

Yes, I also like the style to match the logo design, but it doesn't have good contrast with some logos, so I just reversed the colors.
I don't understand about the black outline, can you provide a reference? So I could give it a try.

Yes, I like the way you have inverted the colour. My suggestion is to add an extra black outline. So it would be, black - yellow - black - yellow like the logo. The original has this black outline, notice when this line connects with the logo, it looks better in my opinion.

You mean something like this?

Screenshot_2023-01-08_11-43-51

@1fbr
Copy link
Contributor

1fbr commented Jan 8, 2023

@Felix-Icaza Yes, what do you think?

@felixicaza
Copy link
Contributor Author

@Felix-Icaza Yes, what do you think?

It makes a lot of sense your suggestion. I just added a new suggestion where I add a shadow and attached fullscreen screenshots for better viewing, you can take a look at it.

I will draft the PR while we can decide.

@felixicaza felixicaza marked this pull request as draft January 8, 2023 18:26
@1fbr
Copy link
Contributor

1fbr commented Jan 8, 2023

It makes a lot of sense your suggestion. I just added a new suggestion where I add a shadow and attached fullscreen screenshots for better viewing, you can take a look at it.

I will draft the PR while we can decide.

Both seem good to me, actually.
It would be good to have more opinions.

@felixicaza
Copy link
Contributor Author

Hi @midudev, what do you think?

@felixicaza felixicaza marked this pull request as ready for review January 10, 2023 00:52
@felixicaza felixicaza closed this by deleting the head repository Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants