-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix header background color #257
Conversation
I assume the current one is like that to try to match the design of the logo. |
Yes, I also like the style to match the logo design, but it doesn't have good contrast with some logos, so I just reversed the colors. I don't understand about the black outline, can you provide a reference? So I could give it a try. |
Yes, I like the way you have inverted the colour. |
You mean something like this? |
@Felix-Icaza Yes, what do you think? |
It makes a lot of sense your suggestion. I just added a new suggestion where I add a shadow and attached fullscreen screenshots for better viewing, you can take a look at it. I will draft the PR while we can decide. |
Both seem good to me, actually. |
Hi @midudev, what do you think? |
This is related with the issue #248.
I'm proposing a new color for the background header, because it does not have good contrast with the team logos.
Current:
(Edit: update proposals)
Option 1:
Option 2 (add black border - pending to commit):
Option 3 (add shadow - pending to commit):