Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support v3 logger #3328

Merged
merged 18 commits into from
Nov 13, 2023
Merged

feat: support v3 logger #3328

merged 18 commits into from
Nov 13, 2023

Conversation

czy88840616
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@czy88840616 czy88840616 added the pr: new feature This PR adds a new API or behavior. label Oct 14, 2023
@czy88840616 czy88840616 added this to the 3.13.x milestone Oct 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (469d3b8) 84.41% compared to head (11ec5b9) 84.44%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3328      +/-   ##
==========================================
+ Coverage   84.41%   84.44%   +0.03%     
==========================================
  Files         476      476              
  Lines       44901    45076     +175     
  Branches     5352     5360       +8     
==========================================
+ Hits        37903    38066     +163     
- Misses       6960     6972      +12     
  Partials       38       38              
Files Coverage Δ
packages/bull/src/config/config.default.ts 100.00% <100.00%> (ø)
packages/core/src/baseFramework.ts 94.22% <100.00%> (-0.07%) ⬇️
packages/core/src/config/config.default.ts 100.00% <100.00%> (ø)
packages/core/src/index.ts 100.00% <ø> (ø)
packages/core/src/interface.ts 100.00% <100.00%> (ø)
packages/core/src/service/configService.ts 97.77% <100.00%> (+0.03%) ⬆️
packages/cron/src/configuration.ts 100.00% <100.00%> (+3.38%) ⬆️
packages/faas/src/config.default.ts 53.33% <100.00%> (ø)
packages/faas/src/interface.ts 100.00% <100.00%> (ø)
packages/grpc/src/comsumer/clients.ts 99.25% <100.00%> (ø)
... and 11 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czy88840616 czy88840616 merged commit a4586da into main Nov 13, 2023
6 checks passed
@czy88840616 czy88840616 deleted the support_v3_logger branch November 13, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new feature This PR adds a new API or behavior.
Development

Successfully merging this pull request may close these issues.

2 participants