-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support bull board using bullmq #4259
feat: support bull board using bullmq #4259
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4259 +/- ##
==========================================
+ Coverage 84.55% 85.23% +0.68%
==========================================
Files 491 528 +37
Lines 46778 50666 +3888
Branches 5601 6013 +412
==========================================
+ Hits 39551 43184 +3633
- Misses 7191 7453 +262
+ Partials 36 29 -7 ☔ View full report in Codecov by Sentry. |
不依赖发包吧,都是 monorepo |
const apps = this.applicationManager.getApplications([ | ||
'express', | ||
'egg', | ||
'koa', | ||
]); | ||
if (apps.length) { | ||
apps.forEach(app => { | ||
app.useMiddleware(BoardMiddleware); | ||
if (queuePackage === 'bull') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import { BullBoardOption } from './interface'; | ||
import { BullBoardManager } from './board.manager'; | ||
|
||
const MIME_MAP = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感觉是不是不太需要复制一个出来 🤔
* chore: update * chore: update * feat: support bull board using bullmq (#4259) Co-authored-by: gqc <[email protected]> * refactor: bull-board * fix: case * test: add more case * docs: update * docs: update * docs: update * fix: merge config * fix: try to fix test * fix: lint --------- Co-authored-by: harperKKK <[email protected]> Co-authored-by: gqc <[email protected]>
Checklist
npm test
passesAffected core subsystem(s)
pacakges/bull-board
Description of change
@midwayjs/bull-board 支持显示 bullmq 队列
不确定在github单测跑不跑的过 @midwayjs/bullmq 包还没发