Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support bull board using bullmq #4259

Merged

Conversation

harperKKK
Copy link
Contributor

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

pacakges/bull-board

Description of change

@midwayjs/bull-board 支持显示 bullmq 队列
不确定在github单测跑不跑的过 @midwayjs/bullmq 包还没发

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 75.26882% with 46 lines in your changes missing coverage. Please review.

Project coverage is 85.23%. Comparing base (a3ca53b) to head (a4a2f03).
Report is 531 commits behind head on main.

Files with missing lines Patch % Lines
packages/bull-board/src/bullmq.board.middleware.ts 73.41% 46 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4259      +/-   ##
==========================================
+ Coverage   84.55%   85.23%   +0.68%     
==========================================
  Files         491      528      +37     
  Lines       46778    50666    +3888     
  Branches     5601     6013     +412     
==========================================
+ Hits        39551    43184    +3633     
- Misses       7191     7453     +262     
+ Partials       36       29       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czy88840616
Copy link
Member

不依赖发包吧,都是 monorepo

const apps = this.applicationManager.getApplications([
'express',
'egg',
'koa',
]);
if (apps.length) {
apps.forEach(app => {
app.useMiddleware(BoardMiddleware);
if (queuePackage === 'bull') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import { BullBoardOption } from './interface';
import { BullBoardManager } from './board.manager';

const MIME_MAP = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉是不是不太需要复制一个出来 🤔

@czy88840616 czy88840616 changed the base branch from main to refactor_bullmq January 11, 2025 16:26
@czy88840616 czy88840616 merged commit b343fd2 into midwayjs:refactor_bullmq Jan 11, 2025
7 checks passed
@czy88840616 czy88840616 added pr: polish This PR adds a very minor behavior improvement that users will enjoy. pr: new feature This PR adds a new API or behavior. and removed pr: polish This PR adds a very minor behavior improvement that users will enjoy. labels Jan 11, 2025
czy88840616 added a commit that referenced this pull request Jan 14, 2025
* chore: update

* chore: update

* feat: support bull board using bullmq (#4259)

Co-authored-by: gqc <[email protected]>

* refactor: bull-board

* fix: case

* test: add more case

* docs: update

* docs: update

* docs: update

* fix: merge config

* fix: try to fix test

* fix: lint

---------

Co-authored-by: harperKKK <[email protected]>
Co-authored-by: gqc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new feature This PR adds a new API or behavior.
Development

Successfully merging this pull request may close these issues.

3 participants