Permission handling in image picker #334
+503
−67
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| // The MIT License (MIT) | ||
| // | ||
| // Copyright (c) 2021 Mithilesh Parmar | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| // of this software and associated documentation files (the "Software"), to deal | ||
| // in the Software without restriction, including without limitation the rights | ||
| // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| // copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in all | ||
| // copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| // SOFTWARE. | ||
|
|
||
| import UIKit | ||
| import Photos | ||
|
|
||
| extension AssetsViewController { | ||
| internal func showAlertForRestricedOrNotDeterminedAccess(){ | ||
|
|
||
| let localizedTitle = NSLocalizedString("bsimagepicker.restrictedAccess.alert.title", | ||
| value: "Allow access to your photos", | ||
| comment: "Title of alert controller") | ||
|
|
||
| let localizedMessage = NSLocalizedString("bsimagepicker.restrictedAccess.alert.message", | ||
| value: "This lets you share from your camera roll and enables other features for photos. Go to your settings and tap \"Photos\".", | ||
| comment: "Message of alert controller") | ||
|
|
||
| let notNowLocalizedText = NSLocalizedString("bsimagepicker.restrictedAccess.alert.secondaryButton.title", | ||
| value: "Not now", | ||
| comment: "Secondary button title") | ||
|
|
||
| let openSettinsgLocalizedText = NSLocalizedString("bsimagepicker.restrictedAccess.alert.openSettings.title", | ||
| value: "Open Settings", | ||
| comment: "Primart button title") | ||
|
|
||
| let alert = UIAlertController(title: localizedTitle, message: localizedMessage, preferredStyle: .alert) | ||
|
|
||
| let notNowAction = UIAlertAction(title: notNowLocalizedText, style: .cancel, handler: nil) | ||
| alert.addAction(notNowAction) | ||
|
|
||
| let openSettingsAction = UIAlertAction(title: openSettinsgLocalizedText, style: .default) { [unowned self] (_) in | ||
| // Open app privacy settings | ||
| gotoAppPrivacySettings() | ||
| } | ||
| alert.addAction(openSettingsAction) | ||
| present(alert, animated: true, completion: nil) | ||
| } | ||
|
|
||
| internal func showAlerForLimitedAccess(){ | ||
|
|
||
| let localizedTitle = NSLocalizedString("bsimagepicker.limitedAccess.alert.title", | ||
| value: " ", | ||
| comment: "Title of Alert controller") | ||
|
|
||
| let localizedMessage = NSLocalizedString("bsimagepicker.limitedAccess.alert.message", | ||
| value: "Select more photos or go to Settings to allow access to all photos.", | ||
| comment: "Message of Alert controller") | ||
|
|
||
| let selectMorePhotosLocalizedText = NSLocalizedString("bsimagepicker.limitedAccess.alert.selectMorePhotos", | ||
| value: "Select more photos", | ||
| comment: "Select more photos action title") | ||
|
|
||
| let allowAccessToAllPhotosLocalizedText = NSLocalizedString("bsimagepicker.limitedAccess.alert.allowAccessToAllPhotos", | ||
| value: "Allow access to all photos", | ||
| comment: "Allow access to all photos action title") | ||
|
|
||
| let cancelLocalizedText = NSLocalizedString("bsimagepicker.cancel", | ||
| value: "Cancel", | ||
| comment: "Cancel action title") | ||
|
|
||
| let actionSheet = UIAlertController(title: localizedTitle, message: localizedMessage, preferredStyle: .actionSheet) | ||
|
|
||
| let selectPhotosAction = UIAlertAction(title: selectMorePhotosLocalizedText, style: .default) { [unowned self] (_) in | ||
| // Show limited library picker | ||
| if #available(iOS 14, *) { | ||
| PHPhotoLibrary.shared().presentLimitedLibraryPicker(from: self) | ||
| } | ||
| } | ||
| actionSheet.addAction(selectPhotosAction) | ||
|
|
||
| let allowFullAccessAction = UIAlertAction(title: allowAccessToAllPhotosLocalizedText, style: .default) { [unowned self] (_) in | ||
| // Open app privacy settings | ||
| self.gotoAppPrivacySettings() | ||
| } | ||
| actionSheet.addAction(allowFullAccessAction) | ||
|
|
||
| let cancelAction = UIAlertAction(title: cancelLocalizedText, style: .cancel, handler: nil) | ||
| actionSheet.addAction(cancelAction) | ||
|
|
||
| present(actionSheet, animated: true, completion: nil) | ||
|
There was a problem hiding this comment. I get crash on iPad because the popoverPresentationController?.sourceView is not set. Send here the "manage" button so sheet is displayed properly |
||
|
|
||
| } | ||
|
|
||
| internal func gotoAppPrivacySettings() { | ||
| guard let url = URL(string: UIApplication.openSettingsURLString), | ||
| UIApplication.shared.canOpenURL(url) else { | ||
| assertionFailure("Not able to open App privacy settings") | ||
| return | ||
| } | ||
|
|
||
| UIApplication.shared.open(url, options: [:], completionHandler: nil) | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| // The MIT License (MIT) | ||
| // | ||
| // Copyright (c) 2021 Mithilesh Parmar | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| // of this software and associated documentation files (the "Software"), to deal | ||
| // in the Software without restriction, including without limitation the rights | ||
| // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| // copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in all | ||
| // copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| // SOFTWARE. | ||
|
|
||
| import UIKit | ||
|
|
||
| extension UIView { | ||
| func runtimeSize()-> CGSize { | ||
| let size: CGSize = self.systemLayoutSizeFitting( | ||
| CGSize(width: UIScreen.main.bounds.width, | ||
| height: UIView.layoutFittingExpandedSize.height), | ||
| withHorizontalFittingPriority: .fittingSizeLevel, | ||
| verticalFittingPriority: .fittingSizeLevel) | ||
| return size | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Primart - typo