Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#40 Traverse rule stack from highest to lowest when matching preferred rules #41

Merged
merged 2 commits into from
Feb 10, 2020
Merged

#40 Traverse rule stack from highest to lowest when matching preferred rules #41

merged 2 commits into from
Feb 10, 2020

Conversation

kpainter-atl
Copy link
Contributor

#40

mike-lischke
mike-lischke requested changes Feb 9, 2020
View reviewed changes
Copy link
Owner

@mike-lischke mike-lischke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think by adding a switch to either evaluate top-down or botton-up this patch becomes acceptable. It's not a perfect solution, but should work the current use case. We may later extend that by using some prioritization scheme.

@mike-lischke mike-lischke merged commit de5433a into mike-lischke:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-lischke mike-lischke mike-lischke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpainter-atl @mike-lischke