Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [2.5]The expression supports filling elements through templates #37280

Merged
merged 1 commit into from
Oct 31, 2024

feat:The expression supports filling elements through templates

7281372
Select commit
Loading
Failed to load commit list.
Merged

feat: [2.5]The expression supports filling elements through templates #37280

feat:The expression supports filling elements through templates
7281372
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 31, 2024 in 1s

80.84% (target 77.00%)

View this Pull Request on Codecov

80.84% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 78.85196% with 140 lines in your changes missing coverage. Please review.

Project coverage is 80.84%. Comparing base (12fb9d6) to head (7281372).
Report is 3 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/parser/planparserv2/utils.go 68.45% 52 Missing and 1 partial ⚠️
internal/parser/planparserv2/parser_visitor.go 78.28% 27 Missing and 21 partials ⚠️
...ernal/parser/planparserv2/fill_expression_value.go 87.97% 17 Missing and 5 partials ⚠️
...lanparserv2/convert_field_data_to_generic_value.go 81.03% 8 Missing and 3 partials ⚠️
internal/parser/planparserv2/node_ret.go 62.50% 2 Missing and 1 partial ⚠️
internal/parser/planparserv2/plan_parser_v2.go 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #37280      +/-   ##
==========================================
- Coverage   83.15%   80.84%   -2.32%     
==========================================
  Files        1029     1321     +292     
  Lines      157316   183133   +25817     
==========================================
+ Hits       130822   148057   +17235     
- Misses      21327    29873    +8546     
- Partials     5167     5203      +36     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 66.95% <ø> (∅)
Go 83.11% <78.85%> (-0.07%) ⬇️
Files with missing lines Coverage Δ
internal/parser/planparserv2/show_visitor.go 93.52% <100.00%> (+3.08%) ⬆️
internal/proxy/task.go 86.98% <ø> (ø)
internal/proxy/task_delete.go 92.43% <100.00%> (ø)
internal/proxy/task_query.go 80.71% <100.00%> (ø)
internal/proxy/task_search.go 76.20% <100.00%> (+0.24%) ⬆️
internal/parser/planparserv2/node_ret.go 75.00% <62.50%> (-5.00%) ⬇️
internal/parser/planparserv2/plan_parser_v2.go 87.19% <75.00%> (-1.08%) ⬇️
...lanparserv2/convert_field_data_to_generic_value.go 81.03% <81.03%> (ø)
...ernal/parser/planparserv2/fill_expression_value.go 87.97% <87.97%> (ø)
internal/parser/planparserv2/parser_visitor.go 85.95% <78.28%> (-2.56%) ⬇️
... and 1 more

... and 321 files with indirect coverage changes