Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix sorting buffer in clustering compaction #38417

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #28410

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 12, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.90%. Comparing base (c2855a5) to head (c93a06d).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...ternal/datanode/compaction/clustering_compactor.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38417      +/-   ##
==========================================
+ Coverage   80.89%   80.90%   +0.01%     
==========================================
  Files        1376     1376              
  Lines      193089   193089              
==========================================
+ Hits       156198   156226      +28     
+ Misses      31359    31339      -20     
+ Partials     5532     5524       -8     
Components Coverage Δ
Client 74.58% <ø> (ø)
Core 68.91% <ø> (ø)
Go 83.02% <0.00%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
...ternal/datanode/compaction/clustering_compactor.go 65.54% <0.00%> (ø)

... and 17 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 12, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 13, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 6ffc57c into milvus-io:master Dec 13, 2024
19 of 20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants