Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Remove map directory after release #39116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Jan 9, 2025

No description provided.

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jan 9, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sunby
To complete the pull request process, please assign tedxu after the PR has been reviewed.
You can assign the PR to them by writing /assign @tedxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.63%. Comparing base (aceb972) to head (67c03d5).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 20.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (aceb972) and HEAD (67c03d5). Click for more details.

HEAD has 11 uploads less than BASE
Flag BASE (aceb972) HEAD (67c03d5)
12 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39116       +/-   ##
===========================================
- Coverage   81.18%   69.63%   -11.55%     
===========================================
  Files        1390      296     -1094     
  Lines      196755    26638   -170117     
===========================================
- Hits       159732    18549   -141183     
+ Misses      31442     8089    -23353     
+ Partials     5581        0     -5581     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.63% <20.00%> (+0.09%) ⬆️
Go ∅ <ø> (∅)
Files with missing lines Coverage Δ
...ternal/core/src/segcore/ChunkedSegmentSealedImpl.h 28.57% <ø> (ø)
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 22.82% <20.00%> (-0.02%) ⬇️

... and 1099 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Jan 9, 2025

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants