Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test:Add search Iterator v2 test case for milvus client #39120

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

qixuan0212
Copy link
Contributor

issue: #37548

@sre-ci-robot sre-ci-robot added area/test sig/testing size/XL Denotes a PR that changes 500-999 lines. labels Jan 9, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/test labels Jan 9, 2025
Copy link
Contributor

mergify bot commented Jan 9, 2025

@qixuan0212 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 9, 2025

@qixuan0212 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@qixuan0212
Copy link
Contributor Author

rerun go-sdk

@qixuan0212
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jan 9, 2025

@qixuan0212 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@qixuan0212
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jan 10, 2025

@qixuan0212 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@qixuan0212
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jan 13, 2025

@qixuan0212 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@qixuan0212
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jan 14, 2025

@qixuan0212 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@qixuan0212
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jan 15, 2025
@yanliang567
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qixuan0212, yanliang567

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 27a99f6 into milvus-io:master Jan 15, 2025
5 checks passed
@@ -153,6 +153,25 @@ def search(self, client, collection_name, data, limit=10, filter=None, output_fi
**kwargs).run()
return res, check_result

@trace()
def search_interator(self, client, collection_name, data, batch_size=20, limit=100, filter=None, output_fields=None,
search_params=None, timeout=None, check_task=None, check_items=None, **kwargs):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think batch_size=20 is a good default value. it blocks us verify the scenarios ofhe batch_size is none

gifi-siby pushed a commit to gifi-siby/milvus that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants