Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rbac custom group privilege level check #39164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shaoting-huang
Copy link
Contributor

related: #39086

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/test sig/testing test/integration integration test labels Jan 10, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 89.36170% with 10 lines in your changes missing coverage. Please review.

Project coverage is 81.16%. Comparing base (a8a6564) to head (1066eb5).

Files with missing lines Patch % Lines
internal/rootcoord/root_coord.go 86.84% 4 Missing and 1 partial ⚠️
pkg/util/paramtable/rbac_param.go 91.42% 2 Missing and 1 partial ⚠️
internal/rootcoord/meta_table.go 0.00% 1 Missing ⚠️
pkg/util/constant.go 93.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39164       +/-   ##
===========================================
+ Coverage   69.64%   81.16%   +11.51%     
===========================================
  Files         296     1395     +1099     
  Lines       26633   197395   +170762     
===========================================
+ Hits        18548   160206   +141658     
- Misses       8085    31565    +23480     
- Partials        0     5624     +5624     
Components Coverage Δ
Client 79.53% <ø> (∅)
Core 69.64% <ø> (ø)
Go 83.09% <89.36%> (∅)
Files with missing lines Coverage Δ
internal/proxy/impl.go 83.84% <ø> (ø)
internal/proxy/util.go 89.44% <ø> (ø)
internal/rootcoord/rbac_task.go 69.92% <100.00%> (ø)
internal/rootcoord/meta_table.go 83.30% <0.00%> (ø)
pkg/util/constant.go 96.15% <93.33%> (ø)
pkg/util/paramtable/rbac_param.go 97.14% <91.42%> (ø)
internal/rootcoord/root_coord.go 90.02% <86.84%> (ø)

... and 1092 files with indirect coverage changes

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shaoting-huang
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Jan 11, 2025

@shaoting-huang go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 11, 2025

@shaoting-huang go-sdk check failed, comment rerun go-sdk can trigger the job again.

@shaoting-huang
Copy link
Contributor Author

rerun go-sdk

@mergify mergify bot added the ci-passed label Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants