Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T 1331575: Updated Refresh Token API minimumExpirationTime to 5 minutes #169

Merged

Conversation

amrutakamat-mindbody
Copy link
Contributor

This pull request includes (pick all that apply):

  • Bugfixes
  • New features
  • Breaking changes
  • Documentation updates
  • Unit tests
  • Other

Summary

  • The refresh token expiry has been change to 1 hour instead of 24 hours.
  • Previously, the refresh token API call timings before expiry i.e. minimumExpirationTime was set to 900 i.e. 15 minutes for 24 hours.
  • So, updated minimumExpirationTime to 5 minutes.

Implementation

  • It includes a change to the BearerToken struct in the Sources/Conduit/Auth/Models/OAuth2Token.swift file. The minimumExpirationTime for the isValid property has been reduced from 15 minutes to 5 minutes. This change affects how we determine the validity of the token.

Test Plan

  1. Test on all projects and verify refresh token API has been called 5 minutes before expiry.

Copy link
Contributor

@AnshulMindbody AnshulMindbody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amrutakamat-mindbody amrutakamat-mindbody merged commit 0e8ca31 into main Jul 10, 2024
1 check passed
@amrutakamat-mindbody amrutakamat-mindbody deleted the Task/1331575-Update-Refresh-Token-Call-to-5-minutes branch July 10, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants