Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Gateway API (HTTPRoute) to Helm chart #5401

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

evankanderson
Copy link
Member

Summary

Gateway API provides more-modern support for HTTP Routing and GRPC routing compared with Ingress API. Since we (Stacklok) have rolled out https://gateway.envoyproxy.io/, add support for loading GRPC and HTTP routes to Minder, as well as the old Ingress model (which is much longer, and less helpful).

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

I manually loaded these routes into a test cluster with Envoy Gateway installed, and verified that the routes were "accepted". Will do more testing in staging once the chart is deployed.

Note that this does not yet remove the old Ingress objects -- both can be deployed at once in a cluster.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@evankanderson evankanderson requested a review from a team as a code owner February 4, 2025 00:24
@evankanderson
Copy link
Member Author

There is a pending change in our staging cluster to accept GRPC routes, and I'll need one more change to enable the added flags, so don't merge this until I give the all-clear.

@coveralls
Copy link

coveralls commented Feb 4, 2025

Coverage Status

coverage: 57.478%. remained the same
when pulling ace9368 on evankanderson:gateway-routes
into fdc94f0 on mindersec:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants