Change default screen resolution based on device type

minetoblend · Jan 17, 2025 · 585cfdd · 585cfdd
1 parent c1883c9
commit 585cfdd
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 20 deletions.
diff --git a/packages/core/src/OsucadGameBase.ts b/packages/core/src/OsucadGameBase.ts
@@ -1,5 +1,5 @@
 import type { Container, Drawable, PIXIRenderer, ReadonlyDependencyContainer } from '@osucad/framework';
-import { AudioManager, Axes, Box, DependencyContainer, Game, IRenderer, provide, resolved } from '@osucad/framework';
+import { AudioManager, Axes, Box, DependencyContainer, Game, IRenderer, isMobile, provide, resolved, Vec2 } from '@osucad/framework';
 import { OsucadIcons } from '@osucad/resources';
 import { RenderTarget } from 'pixi.js';
 import { AudioMixer } from './audio/AudioMixer';
@@ -38,6 +38,16 @@ export abstract class OsucadGameBase extends Game implements IResourcesProvider
   @provide(ColorProvider)
   colors = new ColorProvider();
 
+  protected getTargetDrawSize() {
+    if (isMobile.phone)
+      return new Vec2(540, 400);
+
+    if (isMobile.any)
+      return new Vec2(640, 640);
+
+    return new Vec2(960, 768);
+  }
+
   protected override load(dependencies: ReadonlyDependencyContainer) {
     super.load(dependencies);
 
@@ -58,10 +68,7 @@ export abstract class OsucadGameBase extends Game implements IResourcesProvider
       }),
       new SafeAreaContainer({
         child: new ScalingContainer({
-          desiredSize: {
-            x: 960,
-            y: 768,
-          },
+          desiredSize: this.getTargetDrawSize(),
           fit: Fit.Fill,
           child: new PerformanceOverlay({
             child: new EditorActionContainer({

diff --git a/packages/core/src/editor/multiplayer/MultiplayerCursorOverlay.ts b/packages/core/src/editor/multiplayer/MultiplayerCursorOverlay.ts
@@ -2,8 +2,8 @@ import type { InputManager, ReadonlyDependencyContainer } from '@osucad/framewor
 import type { CursorPosition } from '@osucad/multiplayer';
 import type { ConnectedUser } from './ConnectedUsers';
 import type { MultiplayerCursorArea } from './MultiplayerCursorArea';
-import { Anchor, Axes, CompositeDrawable, Container, DrawableSprite, MouseButton, ProxyDrawable, resolved, Vec2 } from '@osucad/framework';
-import { getIcon } from '@osucad/resources';
+import { Axes, BindableBoolean, CompositeDrawable, Container, MouseButton, ProxyDrawable, resolved, Vec2 } from '@osucad/framework';
+import { DefaultCursor } from '../../graphics/cursor/DefaultCursorContainer';
 import { MultiplayerClient } from './MultiplayerClient';
 
 export class MultiplayerCursorOverlay extends CompositeDrawable {
@@ -120,20 +120,15 @@ class MultiplayerCursor extends CompositeDrawable {
   ) {
     super();
 
-    this.addInternal(new Container({
-      scale: 0.5,
-      children: [
-        new DrawableSprite({
-          texture: getIcon('select'),
-          anchor: Anchor.TopLeft,
-          x: -5,
-          y: -4,
-          color: this.user.clientInfo.color,
-        }),
-      ],
+    this.addInternal(this.#cursor = new DefaultCursor().with({
+      color: user.clientInfo.color,
     }));
   }
 
+  readonly #cursor: DefaultCursor;
+
+  buttonPressed = new BindableBoolean();
+
   protected override loadComplete() {
     super.loadComplete();
 
@@ -143,13 +138,22 @@ class MultiplayerCursor extends CompositeDrawable {
       if (key === 'cursor')
         this.updatePosition();
     });
+
+    this.buttonPressed.bindValueChanged((e) => {
+      if (e.value)
+        this.#cursor.animateMouseDown();
+      else
+        this.#cursor.animateMouseUp();
+    }, true);
   }
 
   #targetPosition = new Vec2();
 
   updatePosition() {
     const { cursor } = this.user.presence;
 
+    this.buttonPressed.value = cursor?.pressed ?? false;
+
     if (!cursor) {
       this.fadeOut();
       this.setActiveArea(null);

diff --git a/packages/core/src/graphics/cursor/DefaultCursorContainer.ts b/packages/core/src/graphics/cursor/DefaultCursorContainer.ts
@@ -49,15 +49,15 @@ export class DefaultCursor extends CompositeDrawable {
     this.animateMouseUp();
   }
 
-  protected animateMouseDown() {
+  animateMouseDown() {
     this.#sprite.scaleTo(0.8, 1000, EasingFunction.OutQuart);
     this.#sprite.moveTo(new Vec2(-5, -4), 1000, EasingFunction.OutQuart);
 
     this.#shadow.scaleTo(0.8, 1000, EasingFunction.OutQuart);
     this.#shadow.moveTo(new Vec2(-5, -2), 1000, EasingFunction.OutQuart);
   }
 
-  protected animateMouseUp() {
+  animateMouseUp() {
     this.#sprite.scaleTo(1, 200, EasingFunction.OutBack);
     this.#sprite.moveTo(new Vec2(-4, -3), 200, EasingFunction.OutBack);