Fix slider selection blueprint not removing listener on free

minetoblend · Jan 17, 2025 · eba458b · eba458b
1 parent 5baf690
commit eba458b
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/packages/ruleset-osu/src/edit/selection/SliderSelectionBlueprint.ts b/packages/ruleset-osu/src/edit/selection/SliderSelectionBlueprint.ts
@@ -81,7 +81,7 @@ export class SliderSelectionBlueprint extends OsuSelectionBlueprint<Slider> {
 
     const hitObject = entry.hitObject as Slider;
 
-    hitObject.path.invalidated.addListener(this.#updatePositions, this);
+    hitObject.path.invalidated.removeListener(this.#updatePositions, this);
   }
 
   protected override onDefaultsApplied(hitObject: HitObject) {
@@ -166,6 +166,8 @@ export class SliderSelectionBlueprint extends OsuSelectionBlueprint<Slider> {
   }
 
   #updatePositions() {
+    if (!this.hitObject)
+      return;
     this.position = this.hitObject!.stackedPosition;
     this.tailCircle.position = this.hitObject!.path.endPosition;
   }