MinioAdmin: conditionally decrypt response in {attach,detach}_policy …

…APIs (#1472) Signed-off-by: Bala.FA <[email protected]>
minio · Jan 8, 2025 · 6425726 · 6425726
1 parent 06c7dd8
commit 6425726
Showing 1 changed file with 14 additions and 1 deletion.
diff --git a/minio/minioadmin.py b/minio/minioadmin.py
@@ -847,8 +847,21 @@ def _attach_detach_policy(
                 "POST",
                 command,
                 body=encrypt(body, self._provider.retrieve().secret_key),
+                preload_content=False,
             )
-            return response.data.decode()
+            if (
+                    command in [
+                        _COMMAND.IDP_BUILTIN_POLICY_ATTACH,
+                        _COMMAND.IDP_BUILTIN_POLICY_DETACH,
+                    ] and
+                    response.status in [201, 204]
+            ):
+                # Older MinIO servers do not return response.
+                response.close()
+                response.release_conn()
+                return ""
+            data = decrypt(response, self._provider.retrieve().secret_key)
+            return data.decode()
         raise ValueError("either user or group must be set")
 
     def attach_policy_ldap(