Bugfix: Fix a memleak with pollard #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Davidson-Souza
force-pushed
the
fix/pollard-memleak
branch
from
8424d29 to
02e680e
Compare
Davidson-Souza
force-pushed
the
fix/pollard-memleak
branch
from
02e680e to
049a357
Compare
Before this commit we use Rc cycles to represent the forest's trees, but this creates some floating Rc's that never gets dropped, yelding a memory leak. This commit fixes this by using Weak references everywhere except for a node's children, since the node is meant to be owned by it's ancestor. It is ok to upgrade those Weak references because they will never outlive the node itself.
Davidson-Souza
force-pushed
the
fix/pollard-memleak
branch
from
049a357 to
005107e
Compare
Davidson-Souza
added a commit
to Davidson-Souza/rustreexo
that referenced
this pull request
Jun 8, 2024
This reverts commit 6005bc2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit we use Rc cycles to represent the forest's trees, but this creates some floating Rc's that never gets dropped, yelding a memory leak. This commit fixes this by using Weak references everywhere except for a node's children, since the node is meant to be owned by it's ancestor.
It is ok to upgrade those Weak references because they will never outlive the node itself.