fix a bug with MemForest due to off-by-one error #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we try to find in what subtree our node is, we loop over all existing roots. However, this loop is not inclusive, and will never reach the highest tree. If we don't find the tree, it continues with `0` as the tree position, but this is wrong, and will cause problems downstream when we try to use that position. This commit updates the loop and make it inclusive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59
When we try to find in what subtree our node is, we loop over all existing roots. However, this loop is not inclusive, and will never reach the highest tree. If we don't find the tree, it continues with
0as the tree position, but this is wrong, and will cause problems downstream when we try to use that position.This commit updates the loop and make it inclusive