DB interface for mysql, sqlite3 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the repo work by using f.seek(0)
DB interface for mysql, sqlite3
mittsh
approved these changes
Jan 23, 2017
| @@ -218,7 +174,7 @@ def delete_local_backups(dir_path, backup_prefix, backup_extension, verbose = Fa | |||
| default=False, | |||
| ) | |||
| args = parser.parse_args() | |||
|
|
|||
| # Loads configuration file from JSON | |||
| try: | |||
| f=open(args.config_file, 'r') | |||
There was a problem hiding this comment.
ideally one day we should turn all these old style open() to use context managers with…:
|
I can't merge due to conflicts. Would you mind doing a rebase off this repo's |
|
Btw, thanks for all the changes and work on this @divyenduz I'm glad to see that this little project is taking shape and is actually somewhat becoming useful for some! Many thanks 😄 |
|
hey @mittsh, thanks for the quick code review, appreciate it. I was not able to see any conflicts. I have synced this PR with master branch from the upstream repo as well Can this be merged now ? Thanks :) |
|
Yes absolutely! 👍 Thanks a lot for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be initialization of #4
Not very clean right now but later on adding any other DB will be simple implementation of DumpProtocol. That's the vision.
This is just a refactor as of now that retains the functionality.