use aware datetime + better schedule storing #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
suggested changes
Aug 14, 2019
|
@auvipy just now I am in Vacation and without a computer, I Will do it as soon as I can. |
|
Hello @mixkorshun @vindemasi @auvipy ! Could you merge this PR, please🥺? This module is cool, I want to use it for my project. And this fix is very important |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @mixkorshun ,
the PR proposal solve two little issues with scheduler interaction:
use aware datetime solve an issue with last_run date if timezone is configured (in fact after the first reload the stored datetime was interpreted as UTC also if it was relative to a timezone)
changed a bit the interaction between the scheduler and the store. Now changes on beat_schedule config are synced correctly. This solve the issue Old scheduled task is not removed when removed from the list #2 too.
Have a nice day