Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Future return in some methods #136

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Add Future return in some methods #136

merged 1 commit into from
Mar 25, 2024

Conversation

fiqihnurramadhan
Copy link

@fiqihnurramadhan fiqihnurramadhan commented Mar 14, 2024 •
edited
Loading

TLDR

Add Future return in some methods to prevent race condition in async method.

zihejia
zihejia approved these changes Mar 23, 2024
View reviewed changes
Copy link
Contributor

@zihejia zihejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fiqihnurramadhan

@zihejia zihejia merged commit 3ce12d7 into mixpanel:main Mar 25, 2024
3 checks passed
@zihejia zihejia added the enhancement New feature or request label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zihejia zihejia zihejia approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fiqihnurramadhan @zihejia