feat: Add wasm support #167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
martinloesethjensen
approved these changes
Jan 2, 2025
|
could we get this merged in and patch released? thank you for putting this together! i was literally about to open the same pr as i just implemented it myself before seeing this: https://github.com/willsmanley/mixpanel-flutter |
|
also, for wasmgc support, could yall consider including this commit? https://github.com/mixpanel/mixpanel-flutter/pull/175/files this just adds crossorigin to the CDN which allows for wasmgc usage |
|
Could also add section in |
|
Will get back to this today |
|
@willsmanley this is now ready for another review |
|
LGTM but im not a maintainer thank you for incorporating the cross site tag! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133
Test
To test this PR, go to the example folder and try to build the app using Wasm: