refactor: make readConfigFile synchronous
#18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mizdra
force-pushed
the
read-config-sync
branch
from
75645ce to
3355bd7
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the code generator is written in ESM. On the other hand, the entry point for ts-plugin is written in CJS. Therefore, ts-plugin loads code generator modules via dynamic import.
Dynamic import is an asynchronous API. Therefore, ts-plugin uses
createAsyncLanguageServicePluginfor initialisation. However, there are some problems withcreateAsyncLanguageServicePlugin.info.languageServiceasynchronously withcreateAsyncLanguageServicePluginvolarjs/volar.js#257createAsyncLanguageServicePluginis broken when a non-ts file is first opened in VS Code volarjs/volar.js#258To work around these, we would like to initialise ts-plugin synchronously. So, first of all, we want to make config loading synchronous.