simplify check for error message

mjaschen · Jun 27, 2024 · c4aa2c7 · c4aa2c7
1 parent 84a6539
commit c4aa2c7
Showing 1 changed file with 14 additions and 7 deletions.
diff --git a/src/Response/CsvResponse.php b/src/Response/CsvResponse.php
@@ -46,16 +46,18 @@ public function __construct(protected Parser $parser, protected string $response
     public function isError(): bool
     {
         foreach ($this->data as $data) {
-            if ($data[0] === 'MESSAGE' && $data[1] === 'E') {
-                $this->errorCode = $data[2];
-                $this->errorMessage = $data[3];
+            if (!$this->isErrorLine($data)) {
+                continue;
+            }
 
-                if (isset($data[4])) {
-                    $this->errorLine = (int)$data[4];
-                }
+            $this->errorCode = $data[2];
+            $this->errorMessage = $data[3];
 
-                return true;
+            if (isset($data[4])) {
+                $this->errorLine = (int)$data[4];
             }
+
+            return true;
         }
 
         return false;
@@ -155,4 +157,9 @@ private function convertEncodingFromCollmex(array $data): array
 
         return $filter->filterArray($data);
     }
+
+    private function isErrorLine(array $lineData): bool
+    {
+        return $lineData[0] === 'MESSAGE' && $lineData[1] === 'E';
+    }
 }