Fix: Adjusted column alias handling in Select method to avoid empty alias. #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the
Selectmethod by adjusting how the column alias is handled. Previously, an empty alias string could be passed, which would lead to inconsistent SQL queries. With this change, if thecolumnAliasis empty, the column name itself is used as the alias, ensuring more predictable behavior.Changes
Selectmethod to check ifcolumnAliasis empty or null.columnAliasis empty, the column name is used as the alias instead of an empty string.Why
This update prevents issues where empty column aliases could cause SQL query inconsistencies.