WIP feat(cli) add option to disable api in command line #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit-cty
approved these changes
Nov 28, 2024
codecarbon/cli/main.py
Outdated
| type=str, | ||
| default=api_endpoint, | ||
| ) | ||
| overwrite_local_config("api_endpoint", api_endpoint, path=file_path) | ||
|
|
||
| print(f"Logging in to auth server at {AUTH_SERVER_URL}") |
There was a problem hiding this comment.
Suggested change
| print(f"Logging in to auth server at {AUTH_SERVER_URL}") | |
| print(f"Logging into the auth server at {AUTH_SERVER_URL}") |
| @@ -2,6 +2,7 @@ | |||
| import time | |||
| from pathlib import Path | |||
| from typing import Optional | |||
| from uuid import uuid4 | |||
There was a problem hiding this comment.
This import seems to not be used, right ?
There was a problem hiding this comment.
it's used to set a random experiment id, since I thought the experiment id might be needed even with no api.
Not sure though, I have to check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ask the user to enable/disable the api during config