Uuui class #568
Draft
Uuui class #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- **Readability improvement**: we remove the function `last_operations`. - **Correctness**: the operation graph has less bugs (see u.a. "huggingface-c4" or "coco204-mini"): <img width="1160" alt="image" src="https://github.com/mlcommons/croissant/assets/17081356/5ef1ec77-ee02-47df-ada6-95bde116d2c2"> - **Performance improvement**: we remove a Dijkstra+for-loop (`O(n^2)`) in profit of a hashmap storing the last operations (`O(1)`). Example of dataset that used to timeout and is now usable: ```python import mlcroissant as mlc mlc.Dataset("https://datasets-server.huggingface.co/croissant?dataset=gcaillaut/citeseer") ``` More than 700 Hugging Face datasets were similarly impacted (see the [announcement](https://groups.google.com/a/mlcommons.org/g/croissant/c/EpbC0wkuF6g)). Fixes: #310 and #525.
Fixes #501. Full operation graph: <img width="1290" alt="image" src="https://github.com/mlcommons/croissant/assets/17081356/69596061-e69f-44b6-a356-05a30058fb38"> Operation graph for the RecordSet: <img width="329" alt="image" src="https://github.com/mlcommons/croissant/assets/17081356/6a3aae80-17ff-42a4-85f0-9c7a95adef72">
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
|
@ccl-core Can you please rebase? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.