Early return for num_shards==0 in the Beam pipeline. #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
marcenacp
force-pushed
the
feature/efficient-filtering-100
branch
from
b3040e8 to
ae35cc8
Compare
ccl-core
reviewed
Dec 3, 2024
| @@ -195,6 +195,10 @@ def execute_operations_in_beam( | |||
| enumerate(files) | |||
| ) | |||
| num_shards = len(files) | |||
| if not num_shards: | |||
| raise ValueError( | |||
| f"Empty {record_set=}. No file found for filters={json.dumps(filters)}" | |||
ccl-core
approved these changes
Dec 3, 2024
marcenacp
force-pushed
the
feature/efficient-filtering-100
branch
from
4b606dd to
a374fa9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.