Clean code by checking attribute. #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
marcenacp
force-pushed
the
feature/clean-code-after-nerge
branch
from
7e246db to
153374f
Compare
ccl-core
reviewed
Dec 3, 2024
| if not self.parents: | ||
| return None | ||
| raise ValueError(f"node={self} does not have any parent.") |
There was a problem hiding this comment.
There are no nodes that can have no parents? What about the Metadata node?
ccl-core
approved these changes
Dec 3, 2024
marcenacp
force-pushed
the
feature/clean-code-after-nerge
branch
from
153374f to
ac2ea66
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.