Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increase Android minSdkVersion from 21 to 30 #859

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

anhappdev
Copy link
Collaborator

Copy link

github-actions bot commented Feb 27, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@anhappdev anhappdev changed the title chore: Increase Android minSdkVersion to 30 chore: increase Android minSdkVersion to 30 Feb 27, 2024
@anhappdev
Copy link
Collaborator Author

@mohitmundhragithub Can you please help fix the crash on QTI backend:

02-26 23:36:30.204: F/native(26913): cpp/backend_qti/qti_backend_helper.cc:123 runtime 0 is not available on this platform

@mohitmundhragithub
Copy link
Contributor

@mohitmundhragithub Can you please help fix the crash on QTI backend:

02-26 23:36:30.204: F/native(26913): cpp/backend_qti/qti_backend_helper.cc:123 runtime 0 is not available on this platform

I seem to not have permission to view the log files. Can you please help share it?

@anhappdev
Copy link
Collaborator Author

I seem to not have permission to view the log files. Can you please help share it?

Yes.
log.txt

@mohitmundhragithub
Copy link
Contributor

mohitmundhragithub commented Feb 28, 2024

I see this error is causing the test case to fail:

02-26 23:36:30.139: E/audit(1298): type=1400 audit(1709019390.134:12783): avc: denied { read } for pid=26913 comm="DartWorker" name="adsprpc-smd-secure" dev="tmpfs" ino=1396 scontext=u:r:untrusted_app:s0:c78,c257,c512,c768 tcontext=u:object_r:vendor_xdsp_device:s0 tclass=chr_file permissive=0 SEPF_SM-S908U1_12_0001 audit_filtered

MLPerf is considered an untrusted app without some play store key. Seems like with minSDKVersion set to 30, it doesn't allow to read few of the libraries on the devices, for untrusted app.

Can you please share the device's android version? I can check internally to find a workaround for this.
Also, is the device on the latest update already?

@mohitmundhragithub
Copy link
Contributor

I see this error is causing the test case to fail:

02-26 23:36:30.139: E/audit(1298): type=1400 audit(1709019390.134:12783): avc: denied { read } for pid=26913 comm="DartWorker" name="adsprpc-smd-secure" dev="tmpfs" ino=1396 scontext=u:r:untrusted_app:s0:c78,c257,c512,c768 tcontext=u:object_r:vendor_xdsp_device:s0 tclass=chr_file permissive=0 SEPF_SM-S908U1_12_0001 audit_filtered

MLPerf is considered an untrusted app without some play store key. Seems like with minSDKVersion set to 30, it doesn't allow to read few of the libraries on the devices, for untrusted app.

Can you please share the device's android version? I can check internally to find a workaround for this. Also, is the device on the latest update already?

this could be a plausible reason for it: https://developer.android.com/about/versions/10/behavior-changes-10#execute-permission

@anhappdev
Copy link
Collaborator Author

The test device was a Galaxy S22 Ultra, API Level 33

Screenshot 2024-02-29 at 10 46 01

@anhappdev anhappdev force-pushed the 858/increase-min-api-level branch from 5348b5c to 6fec62d Compare June 13, 2024 03:24
@mlcommons mlcommons deleted a comment from sonarqubecloud bot Jun 13, 2024
@mlcommons mlcommons deleted a comment from sonarqubecloud bot Jun 13, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@anhappdev anhappdev changed the title chore: increase Android minSdkVersion to 30 chore: increase Android minSdkVersion from 21 to 30 Jul 7, 2024
@freedomtan
Copy link
Contributor

packing .so file in some other ways? suggestion by @mohitmundhragithub

@freedomtan
Copy link
Contributor

@RSMNYS to check if we can find any other way to pack .so file

@mohitmundhragithub
Copy link
Contributor

mohitmundhragithub commented Aug 20, 2024

@RSMNYS to check if we can find any other way to pack .so file

@freedomtan I checked the GeekbenchAI apk internally. The way they are packing the libs is exactly similar to how we are packing it in the mlperf app.

@anhappdev anhappdev force-pushed the 858/increase-min-api-level branch from b253c65 to 9a6b40a Compare November 1, 2024 07:00
@anhappdev anhappdev marked this pull request as ready for review November 1, 2024 08:18
@anhappdev anhappdev requested a review from a team as a code owner November 1, 2024 08:18
@anhappdev anhappdev added this to the Google Play Store milestone Nov 5, 2024
@anhappdev anhappdev force-pushed the 858/increase-min-api-level branch from 9a6b40a to f9cf156 Compare November 12, 2024 06:37
Copy link

@anhappdev anhappdev merged commit e0f6813 into master Nov 19, 2024
22 checks passed
@anhappdev anhappdev deleted the 858/increase-min-api-level branch November 19, 2024 06:58
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on older devices with API level <= 29
4 participants