Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI layout fixes #955

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

UI layout fixes #955

wants to merge 5 commits into from

Conversation

farook-edev
Copy link

This PR fixes #942 by making sure the app does not clip or overlap elements on extreme screen sizes.

The primary culprit behind the clipping was the many Expanded elements, those were simplified and only the variable size items (such as lists) were allowed to expand.

One bug not mentioned in the issue was also fixed:
image
image

Also added fixes for the following issues as well:
image
image
image

@farook-edev farook-edev requested review from anhappdev and a team as code owners January 30, 2025 11:35
Copy link

github-actions bot commented Jan 30, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@farook-edev farook-edev mentioned this pull request Jan 30, 2025
Copy link
Collaborator

@anhappdev anhappdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI tests failed, and I suspect it's due to the UI changes. To debug the issue, you can run the tests locally using the command make flutter/test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix UI / layout issues with uncommon screen sizes
2 participants