Add unit test for source mixing + Fix naming within tars. #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also makes the markers for sampling case insensitive. |
achalddave
reviewed
Mar 13, 2024
GeorgiosSmyrnis
force-pushed
the
gsmyrnis/mixing_unit_test
branch
from
c4244a7 to
e53b794
Compare
GeorgiosSmyrnis
force-pushed
the
gsmyrnis/mixing_unit_test
branch
from
48a1edb to
a4758cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a unit test for mixing sources, both with and without sampling.
This also fixes the naming scheme within tars, which could cause issues if two sequences within the same tar contained the same tokens - this would also result in the same name within the tarfile, which breaks WebDataset.