Add option to predownload data from s3 at the start of each checkpoint. #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgiosSmyrnis
force-pushed
the
gsmyrnis/improve_s3_dl
branch
2 times, most recently
from
959d8f1 to
101a787
Compare
GeorgiosSmyrnis
force-pushed
the
gsmyrnis/improve_s3_dl
branch
from
101a787 to
d20b585
Compare
achalddave
reviewed
May 22, 2024
open_lm/file_utils.py
Outdated
| stderr=subprocess.PIPE, | ||
| ) | ||
| if result.returncode != 0: | ||
| raise RuntimeError(f"Error: Failed to download data to local storage: {result.stderr.decode('utf-8')}") |
There was a problem hiding this comment.
Should we try this a few times before erroring?
There was a problem hiding this comment.
do we need a barrier after the copy so the other workers don't start reading before worker 0 finishes copying?
There was a problem hiding this comment.
I'll add retries - there is already a dist barrier to make sure the training string is the same across all nodes, so no need to add more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option that allows for predownloading of data at the start of each checkpoint to local storage. This helps with potential s3 errors.