Skip to content

Commit

Permalink
comment out prev/next links pending HELIO-4728
Browse files Browse the repository at this point in the history
  • Loading branch information
conorom committed Jan 8, 2025
1 parent b836d2b commit 3988270
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
10 changes: 6 additions & 4 deletions app/presenters/hyrax/file_set_presenter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -65,20 +65,22 @@ def subjects
parent.subject
end

# TODO: HELIO-4728 - remove these horribly slow methods from MonographPresenter and just index...
# the previous and next ids on the FileSet doc instead (if they exist and are publicly viewable)
def previous_id?
parent.previous_file_sets_id? id
# parent.previous_file_sets_id? id
end

def previous_id
parent.previous_file_sets_id id
# parent.previous_file_sets_id id
end

def next_id?
parent.next_file_sets_id? id
# parent.next_file_sets_id? id
end

def next_id
parent.next_file_sets_id id
# parent.next_file_sets_id id
end

def link_name
Expand Down
5 changes: 3 additions & 2 deletions spec/features/show_file_set_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,9 @@

# arrow links show on non-representative monograph FileSets
visit hyrax_file_set_path(monograph.ordered_members.to_a[2].id)
expect(page).to have_link('Previous', href: monograph.ordered_members.to_a[1].id)
expect(page).to have_link('Next', href: monograph.ordered_members.to_a[3].id)
# TODO: HELIO-4728 - uncomment these assertions
# expect(page).to have_link('Previous', href: monograph.ordered_members.to_a[1].id)
# expect(page).to have_link('Next', href: monograph.ordered_members.to_a[3].id)
end
end

Expand Down

0 comments on commit 3988270

Please sign in to comment.