Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add function to extract information from a model #1213

Closed
wants to merge 1 commit into from

Conversation

be-marc
Copy link
Member

@be-marc be-marc commented Nov 20, 2024

No description provided.

@be-marc
Copy link
Member Author

be-marc commented Nov 20, 2024

Closes #1013 and #899

@be-marc
Copy link
Member Author

be-marc commented Nov 21, 2024

learner = lrn("classif.rpart")
task = tsk("iris")
resampling = rsmp("cv", folds = 3)

extractor = function(learner) list(selected_features = setdiff(learner$model$frame$var, "<leaf>"))

rr = resample(task, learner, resampling, extractor = extractor)
rr$learners[[1]]$state$selected_features

@berndbischl
Copy link
Member

it is not doced where the result of extract is stored

@berndbischl
Copy link
Member

also always doc the signature of the function

@berndbischl
Copy link
Member

also there should be a use case example and test. this should include a benchmark.

a user needs to somehow practilly gain access to the extracted stuff at the end

@be-marc
Copy link
Member Author

be-marc commented Dec 20, 2024

We will implement #1214 instead.

@be-marc be-marc closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants