Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove task prototype when resample #981

Merged
merged 10 commits into from
Dec 21, 2023
Merged

fix: remove task prototype when resample #981

merged 10 commits into from
Dec 21, 2023

Conversation

be-marc
Copy link
Member

@be-marc be-marc commented Dec 7, 2023

No description provided.

sebffischer
sebffischer requested changes Dec 7, 2023
View reviewed changes
Copy link
Member

@sebffischer sebffischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I think we should:

  • Add the column names to the learner state, then after the new version of mlr3 is released, we can change the ordered_features() function from mlr3learners/ mlr3extralearners
  • Start removing the unused data_prototype (?)

R/worker.R Outdated
# repeated saving of the prototype leads to large ResultData objects if the task contains many columns, factor levels or attributes
learner$state$data_prototype = NULL
learner$state$task_prototype = NULL
learner$fallback$state$data_prototype = NULL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check first whether fallback exists.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no error even if the fallback does not exist.

@be-marc
Copy link
Member Author

be-marc commented Dec 7, 2023

Start removing the unused data_prototype (?)

I will open an PR at vetiver.

@sebffischer sebffischer changed the title refactor: remove task prototype when resample perf: remove task prototype when resample Dec 8, 2023
@sebffischer sebffischer changed the title perf: remove task prototype when resample fix: remove task prototype when resample Dec 8, 2023
@sebffischer sebffischer mentioned this pull request Dec 8, 2023
Open
@be-marc
Copy link
Member Author

be-marc commented Dec 13, 2023

Blocked by mlr-org/mlr3learners#278.

@be-marc be-marc merged commit b285c51 into main Dec 21, 2023
3 checks passed
@be-marc be-marc deleted the prototyp branch December 21, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebffischer sebffischer sebffischer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@be-marc @sebffischer