Enables CORS, resolves mmalecki/hock#30 and adds a clearRoutes method #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When an endpoint is defined without a request body, match any request unregarding the real request's body - Fixes hasRoute too.
|
Closing for lack of interest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable CORS (Cross-Origin Resource Sharing)
Add CORS Headers to all responses and always accepts HTTP OPTIONS requests in order to work with XHR requests, e.g.: testing an Angular app with Protractor.
Match routes when Request body is undefined
Resolves issue #30, matching routes regardless the request body content when the route definition didn't specify a body.
Specifying a body on route definition should still match correctly as long as it's specified first.
Clear defined routes
In order to avoid routes overmatching the number of requests, I have added a
clearRoutesto the Hock class which clears the defined routes.