Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python version #233

Closed
wants to merge 1 commit into from
Closed

Update python version #233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ authors = [
]
description = "MEDS ETL and transformation functions leveraging a sharding-based parallelism model & polars."
readme = "README.md"
requires-python = ">=3.11"
requires-python = ">=3.12"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Python 3.12 requirement needs reconsideration

The version update to Python 3.12 raises several concerns:

  • All core dependencies (polars, pyarrow, nested_ragged_tensors) are compatible with Python 3.11
  • The walk_up parameter for Path.relative_to() was actually introduced in Python 3.12, but it's only used in an example file (MIMIC-IV_Example/pre_MEDS.py)
  • Forcing Python 3.12 might unnecessarily restrict users when the codebase could work with 3.11

Recommendations:

  • Keep Python 3.11 requirement and modify the example file to use a different approach for relative path handling
  • Or document the Python 3.12 requirement specifically for the MIMIC-IV example in its README
🔗 Analysis chain

Verify dependency compatibility with Python 3.12

The update to Python 3.12 might impact compatibility with project dependencies. Let's verify the compatibility status of critical dependencies.

Let me check the actual dependencies specified in the project to ensure we have a complete picture.

Let me check if the walkup parameter issue in Path.relative_to is actually resolved in Python 3.12, as this is the stated reason for the version bump.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check Python 3.12 compatibility for key dependencies

# Extract dependencies and check their metadata
for pkg in polars pyarrow nested_ragged_tensors meds; do
  echo "Checking $pkg..."
  curl -s "https://pypi.org/pypi/$pkg/json" | \
    jq -r '.info | "Latest version: " + .version + "\nPython requires: " + .requires_python'
done

Length of output: 1165

Script:

#!/bin/bash
# Get all dependencies from pyproject.toml
cat pyproject.toml | grep -A 50 "dependencies = \["

Length of output: 2631

Script:

#!/bin/bash
# Search for usage of relative_to with walk_up parameter
rg "relative_to.*walk_up" -A 2

Length of output: 269

classifiers = [
"Programming Language :: Python :: 3",
"License :: OSI Approved :: MIT License",
Expand Down
Loading