Skip to content

Commit

Permalink
Only show author image when set
Browse files Browse the repository at this point in the history
Fixes `{nil, "picture"=>nil"}` in `_layouts/about.html` when author image isn't set in `_config.yml`.

Close #34
  • Loading branch information
mmistakes committed Oct 19, 2017
1 parent e3f6e83 commit f42040d
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased] -

### Fixed
- Fixed `{nil, "picture"=>nil"}` in `_layouts/about.html` when author image isn't set. [#34](https://github.com/mmistakes/jekyll-theme-basically-basic/issues/34)

## [1.1.2] - 2017-09-14

### Fixed
Expand Down
4 changes: 3 additions & 1 deletion _layouts/about.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@
</div>
<aside class="entry-sidebar">
{% include author %}
<img class="author-picture" src="{{ author_picture }}" alt="{{ author_name }}">
{% if author_picture %}
<img class="author-picture" src="{{ author_picture }}" alt="{{ author_name }}">
{% endif %}
</aside>
</div>

Expand Down
4 changes: 3 additions & 1 deletion docs/_layouts/about.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@
</div>
<aside class="entry-sidebar">
{% include author %}
<img class="author-picture" src="{{ author_picture }}" alt="{{ author_name }}">
{% if author_picture %}
<img class="author-picture" src="{{ author_picture }}" alt="{{ author_name }}">
{% endif %}
</aside>
</div>

Expand Down

0 comments on commit f42040d

Please sign in to comment.