Improve testing #285
Merged
Improve testing #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* integrates the SI graph plot and streamlines the plots * adds first draft of visualization notebook * adds notebook to docs * updates abbreviate function * updates notebook * adds unit test for abbreviate features * fixed feature_names being None * Delete .github/workflows/autoupdate.yml * 190 add a tutorial notebook for data valuation (#243) * adds useful properties to game and closes #251. (#254) * adds useful properties to game and closes #251. Adds `empty_coalition_value`, `grand_coalition_value` properties to game and allows for a getitem (without computation) of a game. * fixed the setter of _empty/_grand values * fixed the setter of _empty/_grand values * updated empty value * 183 make games be also callable with a tuplelist of tuples (#242) * added possibility of tuple/list of tuple in BaseGame __call__ * Added possibility for to Game coalitions with given player_names * Added possibility to call game based on given player_names * removed player_names property as it caused conflicts * made __call__ annotations for python3.9 * refactor game call with strings * refactor game call of tuple and list * Reimplement _check_coalitions to fewer lines. --------- Co-authored-by: Maximilian <[email protected]> --------- Co-authored-by: Paul Hofman <[email protected]> Co-authored-by: Theo <[email protected]>
# Conflicts: # docs/source/notebooks/data_valuation.ipynb # docs/source/notebooks/sv_calculation.ipynb # shapiq/explainer/utils.py # shapiq/games/base.py # tests/conftest.py # tests/tests_games/test_base_game.py
…sting # Conflicts: # requirements.txt
mmschlk
approved these changes
Dec 20, 2024
mmschlk
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
last commit
test test_permutation_symmetry at test_exact_computer.py failes for the CHII bc the value given for the empty set is nan instead of zero (bc of division through zero)
commit fix typos
commit explainer utils
in test_explainer_utils
callable check. checks the signature of the callable model, could be used in an explainer to check if the model is actually callable.
commit update after merge
@pytest.mark.skip("not possible to implement right now")
def test_class_index() (the second one)
-> checks wheather the given index for the feature to be explained is in bounds, would fail right now.