Fix a bug for ica.get_sources() and add a corresponding test #13068
+25
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeiGeJin
requested review from
cbrnr,
adam2392,
agramfort,
mscheltienne and
dengemann
as code owners
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
for more information, see https://pre-commit.ci
larsoner
requested changes
Jan 17, 2025
There was a problem hiding this comment.
Looks like a good start, just a few minor comments!
You'll also need to add a doc/changes/devel/13068.bugfix.rst with a message like
Fixed ICA processing of concatenated raw instances, by :newcontrib:`Firstname Lastname`.then add your name to doc/changes/names.inc
for more information, see https://pre-commit.ci
Sure! I've got all these done according to your comments. |
drammock
reviewed
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
Fixes #13057.
What does this implement/fix?
It fixes the bug in ica.get_sources() for concatenated raw object.
There is a bug in the ica._source_as_raw function, here it assigns [self.last_samp] to self._last_samps, however self.last_samp is a property function and it seems that if its wrapped in a list, it won't actually call this function until used later. So I change it to first calculate the values and then put them in the list.